Merge lp://qastaging/~sergiusens/snapcraft/sources_for_sources into lp://qastaging/~snappy-dev/snapcraft/core
Proposed by
Sergio Schvezov
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Approved by: | Michael Vogt | ||||
| Approved revision: | 209 | ||||
| Merged at revision: | 208 | ||||
| Proposed branch: | lp://qastaging/~sergiusens/snapcraft/sources_for_sources | ||||
| Merge into: | lp://qastaging/~snappy-dev/snapcraft/core | ||||
| Diff against target: |
75 lines (+27/-6) 1 file modified
snapcraft/repo.py (+27/-6) |
||||
| To merge this branch: | bzr merge lp://qastaging/~sergiusens/snapcraft/sources_for_sources | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Michael Vogt (community) | Approve | ||
| Daniel Holbach (community) | Approve | ||
| Colin Watson (community) | Approve | ||
|
Review via email:
|
|||
Commit message
Allow using local sources through an env var (mostly useful for launchpad building)
Description of the change
In launchpad, geoip does not work so our code gets stuck. For now we will use whatever the builder is using. We need a longer plan strategy for this one.
This code does work on launchpad: https:/
To post a comment you must log in.
Revision history for this message
| Colin Watson (cjwatson) | # |
review:
Approve
Revision history for this message
| Colin Watson (cjwatson) | # |
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Good work, just two small comments.