Snapcraft

Merge lp://qastaging/~sergiusens/snapcraft/testing-fixes into lp://qastaging/~snappy-dev/snapcraft/core

  1. testing-fixes
  2. Merge into core
Proposed by Sergio Schvezov
Status: Merged
Approved by: Leo Arias
Approved revision: 151
Merged at revision: 142
Proposed branch: lp://qastaging/~sergiusens/snapcraft/testing-fixes
Merge into: lp://qastaging/~snappy-dev/snapcraft/core
Prerequisite: lp://qastaging/~sergiusens/snapcraft/validation
Diff against target: 91 lines (+27/-5)
4 files modified
.bzrignore (+3/-0)
debian/control (+1/-0)
runtests.sh (+22/-1)
snapcraft/plugins/qml.py (+1/-4)
To merge this branch: bzr merge lp://qastaging/~sergiusens/snapcraft/testing-fixes
Reviewer Review Type Date Requested Status
Leo Arias (community) Approve
Review via email: mp+269146@code.qastaging.launchpad.net

Commit message

Multiple testing additions

To post a comment you must log in.
Revision history for this message
Leo Arias (elopio) wrote :

Looks good.

What about:

python3 $(which flake8) $SRC_PATHS --ignore=E501

to run flake8?

review: Approve
Revision history for this message
Sergio Schvezov (sergiusens) wrote :

> Looks good.
>
> What about:
>
> python3 $(which flake8) $SRC_PATHS --ignore=E501
>
> to run flake8?

It is good, but I still have to install python-flake8 AND python3-flake8 so I get python-mccabe, python-pep8 and pyflakes which is cruft and I don't like that :-P

Revision history for this message
Zygmunt Krynicki (zyga) wrote :

Just install python3-flake8 and run it via python3 -m

Revision history for this message
Sergio Schvezov (sergiusens) wrote :

On Wed, Aug 26, 2015 at 7:48 AM, Zygmunt Krynicki <
<email address hidden>> wrote:

> Just install python3-flake8 and run it via python3 -m
>

Great, but now I have the problem that I don't want to fail on mccabe and
just report it to start fixing it

I'll switch to this as soon as the complexity lowers from 22 ;-)

Revision history for this message
Snappy Tarmac (snappydevtarmac) wrote :

There are additional revisions which have not been approved in review. Please seek review and approval of these new revisions.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches