Snapcraft

Merge lp://qastaging/~sergiusens/snapcraft/yaml_init into lp://qastaging/~snappy-dev/snapcraft/core

  1. yaml_init
  2. Merge into core
Proposed by Sergio Schvezov
Status: Merged
Approved by: Sergio Schvezov
Approved revision: 166
Merged at revision: 155
Proposed branch: lp://qastaging/~sergiusens/snapcraft/yaml_init
Merge into: lp://qastaging/~snappy-dev/snapcraft/core
Prerequisite: lp://qastaging/~sergiusens/snapcraft/ubuntu-core
Diff against target: 444 lines (+132/-109)
3 files modified
snapcraft/cmds.py (+20/-3)
snapcraft/tests/test_yaml.py (+20/-38)
snapcraft/yaml.py (+92/-68)
To merge this branch: bzr merge lp://qastaging/~sergiusens/snapcraft/yaml_init
Reviewer Review Type Date Requested Status
Leo Arias (community) Approve
Review via email: mp+270325@code.qastaging.launchpad.net

Commit message

Simplifying snapcraft.yaml.Config.__init__

Description of the change

The complexity is no longer 22 but 5 for __init__

To post a comment you must log in.
Revision history for this message
Leo Arias (elopio) wrote :

lgtm. Tests pass here.
I love that now not all the exceptions are sys exit. And thanks for using _ for variable names.

review: Approve
lp://qastaging/~sergiusens/snapcraft/yaml_init updated
164. By Sergio Schvezov

Merged ubuntu-core into yaml_init.

165. By Sergio Schvezov

Merged ubuntu-core into yaml_init.

166. By Sergio Schvezov

Merged ubuntu-core into yaml_init.

Revision history for this message
Michael Vogt (mvo) wrote :

I did not do a full review (unless you want one) but what I see looks very good indeed.

Revision history for this message
Sergio Schvezov (sergiusens) wrote :

On Wed, Sep 9, 2015 at 10:49 AM, Michael Vogt <email address hidden>
wrote:

> I did not do a full review (unless you want one) but what I see looks very
> good indeed.
>

Thanks, an approve (aka full review) would be nice.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches