LAVA Android Test

Merge lp://qastaging/~seth-beinhart/lava-android-test/iozone-parser into lp://qastaging/lava-android-test

  1. iozone-parser
  2. Merge into trunk
Proposed by Seth Beinhart
Status: Merged
Merged at revision: 254
Proposed branch: lp://qastaging/~seth-beinhart/lava-android-test/iozone-parser
Merge into: lp://qastaging/lava-android-test
Diff against target: 123 lines (+87/-4) (has conflicts)
2 files modified
lava_android_test/test_definitions/iozone.py (+73/-4)
lava_android_test/test_definitions/iozone/iozone.sh (+14/-0)
Text conflict in lava_android_test/test_definitions/iozone.py
To merge this branch: bzr merge lp://qastaging/~seth-beinhart/lava-android-test/iozone-parser
Reviewer Review Type Date Requested Status
Yongqin Liu Approve
vishal Pending
Linaro Validation Team Pending
Review via email: mp+158995@code.qastaging.launchpad.net

Description of the change

Created a custom parser for Iozone to extract measurement and add them to the bundle.
I also made it easier for an end-user to use a cross compiled binary not located on the device. They simply need to put it in the Iozone folder and un-comment the section regarding it. The user can also specify multiple commands in the sh file for a broader test coverage.

The advantage of this is external tools can be used to analyze the bundle for trends and spot dramatic changes in performance.

This is based on the latest Iozone3_414 cross compiled for android. If needed I can upload the binary.

To post a comment you must log in.
Revision history for this message
Yongqin Liu (liuyq0307) wrote :

sorry for the late of this review.
could you share the output of "iozone -a -i 0 -i 2 -s 16m -V teststring -b iozone_results" for an example.

The parse logic is a little complicate, it's better to check that with an example.

And please delete the blank lines at the end of file lava_android_test/test_definitions/iozone.py

Revision history for this message
Seth Beinhart (seth-beinhart) wrote :

You can see the full stdout here
https://docs.google.com/file/d/0B7p5eKLGVuC5c3Y4WVlGUnI3ODQ/edit?usp=sharing
A snapshot of the dashboard is here
https://docs.google.com/file/d/0B7p5eKLGVuC5WU1odHl6ekFPems/edit?usp=sharing

I will fix your whitespace concerns soon.

Revision history for this message
Yongqin Liu (liuyq0307) wrote :

> You can see the full stdout here
> https://docs.google.com/file/d/0B7p5eKLGVuC5c3Y4WVlGUnI3ODQ/edit?usp=sharing
> A snapshot of the dashboard is here
> https://docs.google.com/file/d/0B7p5eKLGVuC5WU1odHl6ekFPems/edit?usp=sharing
Sorry, I don't have permisson for this doc

> I will fix your whitespace concerns soon.

Revision history for this message
Seth Beinhart (seth-beinhart) wrote :

Sorry about that. I thought I had set up the folder to have public access. (Thats what I get for being in a hurry)

You should now have full access.

lp://qastaging/~seth-beinhart/lava-android-test/iozone-parser updated
240. By Seth Beinhart

Remove additional lines at the end of iozone.py

Revision history for this message
Seth Beinhart (seth-beinhart) wrote :

Lines removed

Revision history for this message
Yongqin Liu (liuyq0307) wrote :

Sorry for the late.

It's OK, will change some of the coding style when merge.

review: Approve
Revision history for this message
Yongqin Liu (liuyq0307) wrote :

Hi, Seth Beinhart

I merged it with some modification on the conflict, coding style and change for the test_case_id by change the parse name to real_parse.

Please checkout the latest lava-android-test source, try and check it again.

Thanks,
Yongqin Liu

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches