The Sevilerow project

Merge lp://qastaging/~sevilerow-team/sevilerow/app-theme into lp://qastaging/sevilerow

  1. app-theme
  2. Merge into sevilerow
Proposed by Chris Wayne
Status: Merged
Merged at revision: 19
Proposed branch: lp://qastaging/~sevilerow-team/sevilerow/app-theme
Merge into: lp://qastaging/sevilerow
Diff against target: 120 lines (+81/-0)
7 files modified
system/custom/home/.config/ubuntu-ui-toolkit/theme.ini (+2/-0)
system/custom/home/.config/upstart/setuptheme.conf (+8/-0)
system/custom/pre-session.d/02setupthemedir (+3/-0)
system/custom/usr/share/themes/UbuntuCustom/Themes/Custom/MainViewStyle.qml (+25/-0)
system/custom/usr/share/themes/UbuntuCustom/Themes/Custom/Palette.qml (+41/-0)
system/custom/usr/share/themes/UbuntuCustom/Themes/Custom/parent_theme (+1/-0)
system/custom/usr/share/themes/UbuntuCustom/Themes/Custom/qmldir (+1/-0)
To merge this branch: bzr merge lp://qastaging/~sevilerow-team/sevilerow/app-theme
Reviewer Review Type Date Requested Status
Scott Sweeny (community) Approve
Review via email: mp+184482@code.qastaging.launchpad.net

Description of the change

App theming

To post a comment you must log in.
Revision history for this message
Scott Sweeny (ssweeny) wrote :

So the MainViewStyle.qml file is just part of inheriting from Ambiance? What is the difference between/why is this needed in addition to parent_theme?

review: Needs Information
Revision history for this message
Sean Feole (sfeole) wrote :

I was able to test successfully test these proposed changes on my nexus4. The blue font carried out to all assorted applications such as Gallery, Calendar, Notes

Revision history for this message
Chris Wayne (cwayne) wrote :

So what the MainViewStyle.qml is doing now is telling it to use the background/etc of Ambiance, otherwise it tries to choose a theme based on the background color, and ignores the new theme

Revision history for this message
Chris Wayne (cwayne) wrote :

parent_theme allows the theme to use all of the different styles int he parent theme (i.e. ProgressBarStyle, TabBarStyle, etc) while setting internals.theme is stopping the automatic choosing of a theme based on color

Revision history for this message
Scott Sweeny (ssweeny) wrote :

Approved with the condition that the workaround be removed when the upstream bug is fixed.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: