The Sevilerow project

Merge lp://qastaging/~sevilerow-team/sevilerow/billing-demo into lp://qastaging/sevilerow

  1. billing-demo
  2. Merge into sevilerow
Proposed by Michał Karnicki
Status: Merged
Approved by: Michał Karnicki
Approved revision: 45
Merged at revision: 46
Proposed branch: lp://qastaging/~sevilerow-team/sevilerow/billing-demo
Merge into: lp://qastaging/sevilerow
Diff against target: 109 lines (+25/-0)
2 files modified
system/custom/vendor/music/music.rss (+20/-0)
system/custom/xdg/data/unity/scopes/music.scope (+5/-0)
To merge this branch: bzr merge lp://qastaging/~sevilerow-team/sevilerow/billing-demo
Reviewer Review Type Date Requested Status
Matt Fischer (community) Approve
Review via email: mp+188461@code.qastaging.launchpad.net

Description of the change

Add more data to music.rss and category to music.scope to configure music scope for billing demo.

To post a comment you must log in.
Revision history for this message
Matt Fischer (mfisch) wrote :

What testing did you perform?

Revision history for this message
Michał Karnicki (karni) wrote :

Verbatim copy works on our other customization, they run same unity8 code, which requires this metadata.

Revision history for this message
Matt Fischer (mfisch) wrote :

Does this work without your custom unity hack?

lp://qastaging/~sevilerow-team/sevilerow/billing-demo updated
45. By Michał Karnicki

Review fixes.

Revision history for this message
Michał Karnicki (karni) wrote :

Flashed sevilerow, manually adb push'ed two files that are touched in this commit to their adequate locations, rebooted. Shell seems to be working fine.

* Yep, I did found at least one typo in XML.

Revision history for this message
Matt Fischer (mfisch) wrote :

WHat about the Music files themselves? Do you need those?

Revision history for this message
Michał Karnicki (karni) wrote :

For the demo, yes. If they're not there, it doesn't matter. Nothing crashes.

Revision history for this message
Matt Fischer (mfisch) wrote :

Approved per
<karni> mfisch: What do you mean whether I need the music files? For the demo, yes. If they're not there, it doesn't matter. Nothing crashes.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: