The Sevilerow project

Merge lp://qastaging/~sevilerow-team/sevilerow/tests-cleanup-and-buildid into lp://qastaging/~sevilerow-team/sevilerow/tests

  1. tests-cleanup-and-buildid
  2. Merge into tests
Proposed by Matt Fischer
Status: Merged
Approved by: Sean Feole
Approved revision: 19
Merged at revision: 16
Proposed branch: lp://qastaging/~sevilerow-team/sevilerow/tests-cleanup-and-buildid
Merge into: lp://qastaging/~sevilerow-team/sevilerow/tests
Diff against target: 246 lines (+32/-72)
11 files modified
tests/test_bookmarks.py (+1/-8)
tests/test_build.py (+23/-0)
tests/test_clickapps.py (+1/-7)
tests/test_customization_enabled.py (+2/-9)
tests/test_customized_applications.py (+1/-9)
tests/test_dconf.py (+0/-3)
tests/test_ringtone.py (+1/-9)
tests/test_scopes.py (+1/-5)
tests/test_sms.py (+1/-8)
tests/test_themes.py (+0/-4)
tests/test_upstartjobs.py (+1/-10)
To merge this branch: bzr merge lp://qastaging/~sevilerow-team/sevilerow/tests-cleanup-and-buildid
Reviewer Review Type Date Requested Status
Sean Feole Approve
Matt Fischer (community) Needs Resubmitting
Review via email: mp+187337@code.qastaging.launchpad.net

Description of the change

Add a test for the build_id. Simplify some tests and removed unused stuff.

UNTESTED

To post a comment you must log in.
lp://qastaging/~sevilerow-team/sevilerow/tests-cleanup-and-buildid updated
17. By Matt Fischer

fixing the build_id test name

Revision history for this message
Chris Wayne (cwayne) wrote :

Should 158 and 176 have the , "r" at the end

lp://qastaging/~sevilerow-team/sevilerow/tests-cleanup-and-buildid updated
18. By Matt Fischer

Fixing an errant "r" left over from switching open to exists

Revision history for this message
Matt Fischer (mfisch) wrote :

No it should not. Fixed.

review: Needs Resubmitting
Revision history for this message
Sean Feole (sfeole) wrote :

I was able to test this on the phone, all of the tests passed and displayed the expected output.

The scopes test failed however I believe it's simply out of date.

lp://qastaging/~sevilerow-team/sevilerow/tests-cleanup-and-buildid updated
19. By Matt Fischer

Adding ebooks to the scope list and cleanup

Revision history for this message
Sean Feole (sfeole) wrote :

Awesome, thanks for adding the ebook scope update.. LGTM

Tested on my N4

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: