Charm Helpers

Merge lp://qastaging/~seyeongkim/charm-helpers/fixing-filenotfounderror into lp://qastaging/charm-helpers

  1. fixing-filenotfounderror
  2. Merge into devel
Proposed by Seyeong Kim
Status: Merged
Merged at revision: 786
Proposed branch: lp://qastaging/~seyeongkim/charm-helpers/fixing-filenotfounderror
Merge into: lp://qastaging/charm-helpers
Diff against target: 22 lines (+6/-1)
1 file modified
charmhelpers/core/hookenv.py (+6/-1)
To merge this branch: bzr merge lp://qastaging/~seyeongkim/charm-helpers/fixing-filenotfounderror
Reviewer Review Type Date Requested Status
Stuart Bishop (community) Approve
Review via email: mp+329727@code.qastaging.launchpad.net

This proposal supersedes a proposal from 2017-08-28.

Description of the change

ignore FileNotFoundError when getting metadata file on the other machine's unit

related bug is https://bugs.launchpad.net/nrpe-charm/+bug/1712977

To post a comment you must log in.
Revision history for this message
Stuart Bishop (stub) wrote : Posted in a previous version of this proposal

FileNotFoundError doesn't exist with older Python releases. Its probably best to return None if 'not os.path.exists' rather than catch the exception.

review: Needs Fixing
Revision history for this message
Stuart Bishop (stub) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches