Juju Charms Collection
swift-storage package

Merge lp://qastaging/~seyeongkim/charms/trusty/swift-storage/lp1375395 into lp://qastaging/~openstack-charmers-archive/charms/trusty/swift-storage/next

  1. Trusty Tahr (14.04)
  2. lp1375395
  3. Merge into next
Proposed by Seyeong Kim
Status: Merged
Merged at revision: 60
Proposed branch: lp://qastaging/~seyeongkim/charms/trusty/swift-storage/lp1375395
Merge into: lp://qastaging/~openstack-charmers-archive/charms/trusty/swift-storage/next
Diff against target: 140 lines (+73/-7)
3 files modified
unit_tests/test_swift_storage_context.py (+13/-0)
unit_tests/test_swift_storage_relations.py (+45/-7)
unit_tests/test_swift_storage_utils.py (+15/-0)
To merge this branch: bzr merge lp://qastaging/~seyeongkim/charms/trusty/swift-storage/lp1375395
Reviewer Review Type Date Requested Status
OpenStack Charmers Pending
Edward Hope-Morley Pending
Review via email: mp+250892@code.qastaging.launchpad.net

This proposal supersedes a proposal from 2015-01-28.

To post a comment you must log in.
Revision history for this message
Seyeong Kim (seyeongkim) wrote : Posted in a previous version of this proposal

need an advice for this part

because of using - not _ on private-address, got error

#self.relation_set.assert_called_with(
# device='vdb', object_port=6000, account_port=6002,
# zone=1, container_port=6001, private-address='FE80:0000:0000:0000:0202:B3FF:FE1E:8329',
#)
# private-address : keyword can't be an expression

Revision history for this message
Edward Hope-Morley (hopem) wrote : Posted in a previous version of this proposal

Seyeong, you could try using a dict i.e.:

args = {'device': 'vdb', 'object_port': 6000, 'account_port': 6002,
        'zone': 1, 'container_port': 6001, 'private-address': 'FE80:0000:0000:0000:0202:B3FF:FE1E:8329'}
self.relation_set.assert_called_with(**args)

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote : Posted in a previous version of this proposal

charm_unit_test #1464 swift-storage-next for xtrusia mp247789
    UNIT OK: passed

Build: http://10.245.162.77:8080/job/charm_unit_test/1464/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote : Posted in a previous version of this proposal

charm_lint_check #1509 swift-storage-next for xtrusia mp247789
    LINT FAIL: lint-test failed

LINT Results (max last 2 lines):
  unit_tests/test_swift_storage_utils.py:238:64: E231 missing whitespace after ':'
  make: *** [lint] Error 1

Full lint test output: http://paste.ubuntu.com/10033239/
Build: http://10.245.162.77:8080/job/charm_lint_check/1509/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote : Posted in a previous version of this proposal

charm_amulet_test #1628 swift-storage-next for xtrusia mp247789
    AMULET OK: passed

Build: http://10.245.162.77:8080/job/charm_amulet_test/1628/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote : Posted in a previous version of this proposal

charm_lint_check #1510 swift-storage-next for xtrusia mp247789
    LINT OK: passed

Build: http://10.245.162.77:8080/job/charm_lint_check/1510/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote : Posted in a previous version of this proposal

charm_unit_test #1465 swift-storage-next for xtrusia mp247789
    UNIT OK: passed

Build: http://10.245.162.77:8080/job/charm_unit_test/1465/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote : Posted in a previous version of this proposal

charm_amulet_test #1629 swift-storage-next for xtrusia mp247789
    AMULET OK: passed

Build: http://10.245.162.77:8080/job/charm_amulet_test/1629/

Revision history for this message
Edward Hope-Morley (hopem) wrote : Posted in a previous version of this proposal

Seyeong, thanks a lot for adding in new tests it is much appreciated! I have one inline question regarding one of your tests but apart from that this looks good.

Revision history for this message
Seyeong Kim (seyeongkim) : Posted in a previous version of this proposal
Revision history for this message
Edward Hope-Morley (hopem) wrote : Posted in a previous version of this proposal

See inline.

Revision history for this message
Edward Hope-Morley (hopem) : Posted in a previous version of this proposal
review: Needs Fixing
Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_lint_check #2281 swift-storage-next for xtrusia mp250892
    LINT OK: passed

Build: http://10.245.162.77:8080/job/charm_lint_check/2281/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_unit_test #2070 swift-storage-next for xtrusia mp250892
    UNIT OK: passed

Build: http://10.245.162.77:8080/job/charm_unit_test/2070/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_amulet_test #2186 swift-storage-next for xtrusia mp250892
    AMULET FAIL: amulet-test failed

AMULET Results (max last 2 lines):
  ERROR subprocess encountered error code 1
  make: *** [test] Error 1

Full amulet test output: http://paste.ubuntu.com/10405504/
Build: http://10.245.162.77:8080/job/charm_amulet_test/2186/

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches