MAAS

Merge ~seyeongkim/maas:adding_system_id_for_filtering into maas:master

  1. Git
  2. lp:~seyeongkim/maas
  3. adding_system_id_for_filtering
  4. Merge into master
Proposed by Seyeong Kim
Status: Merged
Approved by: Jacopo Rota
Approved revision: 118ba84a7a5147112226c8e32e6a5f8c84d40523
Merge reported by: MAAS Lander
Merged at revision: not available
Proposed branch: ~seyeongkim/maas:adding_system_id_for_filtering
Merge into: maas:master
Diff against target: 86 lines (+25/-0)
3 files modified
src/maasserver/node_constraint_filter_forms.py (+8/-0)
src/maasserver/tests/test_node_constraint_filter_forms.py (+10/-0)
src/maasserver/websockets/handlers/tests/test_machine.py (+7/-0)
Reviewer Review Type Date Requested Status
Jacopo Rota Approve
MAAS Lander Approve
Review via email: mp+472866@code.qastaging.launchpad.net

Commit message

fix(maasserver): Adding system_id for filtering in UI

Adding system_id for filtering

Resolves LP:2078810

To post a comment you must log in.
Revision history for this message
MAAS Lander (maas-lander) wrote :

UNIT TESTS
-b adding_system_id_for_filtering lp:~seyeongkim/maas/+git/maas into -b master lp:~maas-committers/maas

STATUS: SUCCESS
COMMIT: 22b3161f960336eb02b50af78e9178beba69fca1

review: Approve
Revision history for this message
Jacopo Rota (r00ta) wrote (last edit ):

Thanks for the contribution! Mind adding a small unit test?

review: Needs Fixing
Revision history for this message
Seyeong Kim (seyeongkim) wrote :

hey @r00ta,

sure, I have a question

FREETEXT_EXCLUDES has

"not_system_id": ("system_id", _match_substring),

do i need to remove this line theoretically if I want to allow system_id filtering?

in my test, it is ok even if I don't remove it.

Thanks.

Revision history for this message
MAAS Lander (maas-lander) wrote :

UNIT TESTS
-b adding_system_id_for_filtering lp:~seyeongkim/maas/+git/maas into -b master lp:~maas-committers/maas

STATUS: FAILED
LOG: http://maas-ci.internal:8080/job/maas-tester/342/console
COMMIT: e1f874f99d96e561589cef76291e79a35cbebbb6

review: Needs Fixing
Revision history for this message
Seyeong Kim (seyeongkim) wrote :

jenkins: !test

Revision history for this message
MAAS Lander (maas-lander) wrote :

UNIT TESTS
-b adding_system_id_for_filtering lp:~seyeongkim/maas/+git/maas into -b master lp:~maas-committers/maas

STATUS: FAILED
LOG: http://maas-ci.internal:8080/job/maas-tester/360/console
COMMIT: e1f874f99d96e561589cef76291e79a35cbebbb6

review: Needs Fixing
Revision history for this message
Jacopo Rota (r00ta) wrote (last edit ):

> hey @r00ta,
>
> sure, I have a question
>
> FREETEXT_EXCLUDES has
>
> "not_system_id": ("system_id", _match_substring),
>
> do i need to remove this line theoretically if I want to allow system_id
> filtering?
>
> in my test, it is ok even if I don't remove it.
>
> Thanks.

IIRC that structure is used to make the negation conditions (for example, find the machines NOT in a fabric) so you don't need to modify it

Revision history for this message
MAAS Lander (maas-lander) wrote :

UNIT TESTS
-b adding_system_id_for_filtering lp:~seyeongkim/maas/+git/maas into -b master lp:~maas-committers/maas

STATUS: FAILED
LOG: http://maas-ci.internal:8080/job/maas-tester/362/console
COMMIT: 0e2c9c9ad5806825a11d265fc90d68be675e140c

review: Needs Fixing
Revision history for this message
MAAS Lander (maas-lander) wrote :

UNIT TESTS
-b adding_system_id_for_filtering lp:~seyeongkim/maas/+git/maas into -b master lp:~maas-committers/maas

STATUS: FAILED
LOG: http://maas-ci.internal:8080/job/maas-tester/409/console
COMMIT: a3be3f87d14568a7e27464896799b65b54a8f7d8

review: Needs Fixing
Revision history for this message
Seyeong Kim (seyeongkim) wrote :

local unit test doesn't have issue but it fails here. and I can't access to maas-ci.internal even if I use company vpn.. I'm checking with colleague and if there is way to solve it.

Revision history for this message
Seyeong Kim (seyeongkim) wrote :

jenkins: !test

Revision history for this message
MAAS Lander (maas-lander) wrote :

UNIT TESTS
-b adding_system_id_for_filtering lp:~seyeongkim/maas/+git/maas into -b master lp:~maas-committers/maas

STATUS: FAILED
LOG: http://maas-ci.internal:8080/job/maas-tester/559/console
COMMIT: a3be3f87d14568a7e27464896799b65b54a8f7d8

review: Needs Fixing
Revision history for this message
Seyeong Kim (seyeongkim) wrote :

jenkins: !test

Revision history for this message
MAAS Lander (maas-lander) wrote :

UNIT TESTS
-b adding_system_id_for_filtering lp:~seyeongkim/maas/+git/maas into -b master lp:~maas-committers/maas

STATUS: FAILED
LOG: http://maas-ci.internal:8080/job/maas-tester/561/console
COMMIT: a3be3f87d14568a7e27464896799b65b54a8f7d8

review: Needs Fixing
Revision history for this message
MAAS Lander (maas-lander) wrote :

UNIT TESTS
-b adding_system_id_for_filtering lp:~seyeongkim/maas/+git/maas into -b master lp:~maas-committers/maas

STATUS: FAILED
LOG: http://maas-ci.internal:8080/job/maas-tester/563/console
COMMIT: 6bc76747a5eac431c931bc0d2dcd4e8bacb3a7d9

review: Needs Fixing
Revision history for this message
MAAS Lander (maas-lander) wrote :

UNIT TESTS
-b adding_system_id_for_filtering lp:~seyeongkim/maas/+git/maas into -b master lp:~maas-committers/maas

STATUS: SUCCESS
COMMIT: 118ba84a7a5147112226c8e32e6a5f8c84d40523

review: Approve
Revision history for this message
Jacopo Rota (r00ta) wrote :

lgtm, thanks!

review: Approve

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches