Code review comment for lp://qastaging/~shanepatrickfagan/unity/unity-replace

Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

Hi Fagan, thanks for the merge request and your work there.

I definitively see the added value of such an option to users. However, I think that we should make it clear that the design decision is to make it useless. This should be noted in the Help of the switch (maybe even adding an "compatibility" option group) and print a warning when using it telling it's useless.

review: Needs Fixing

« Back to merge proposal