Merge lp://qastaging/~sharan-monikantan/drizzle/trunk-bug-723915-complete into lp://qastaging/drizzle

Proposed by Patrick Crews
Status: Needs review
Proposed branch: lp://qastaging/~sharan-monikantan/drizzle/trunk-bug-723915-complete
Merge into: lp://qastaging/drizzle
Diff against target: 2145 lines (+1856/-43)
23 files modified
plugin/logging_query/tests/parse-query-log.sh (+1/-1)
plugin/logging_query/tests/r/blob.result (+46/-0)
plugin/logging_query/tests/r/create.result (+61/-0)
plugin/logging_query/tests/r/datatypes_datetime.result (+117/-0)
plugin/logging_query/tests/r/datatypes_numeric.result (+97/-0)
plugin/logging_query/tests/r/datatypes_string.result (+62/-0)
plugin/logging_query/tests/r/delete.result (+104/-0)
plugin/logging_query/tests/r/file.result (+36/-11)
plugin/logging_query/tests/r/insert.result (+85/-0)
plugin/logging_query/tests/r/select.result (+130/-0)
plugin/logging_query/tests/r/thresholds.result (+11/-7)
plugin/logging_query/tests/r/update.result (+62/-0)
plugin/logging_query/tests/t/blob.test (+84/-0)
plugin/logging_query/tests/t/create.test (+80/-0)
plugin/logging_query/tests/t/datatypes_datetime.test (+151/-0)
plugin/logging_query/tests/t/datatypes_numeric.test (+126/-0)
plugin/logging_query/tests/t/datatypes_string.test (+111/-0)
plugin/logging_query/tests/t/delete.test (+152/-0)
plugin/logging_query/tests/t/file.bak (+33/-24)
plugin/logging_query/tests/t/insert.test (+87/-0)
plugin/logging_query/tests/t/select.test (+128/-0)
plugin/logging_query/tests/t/thresholds.bak (+4/-0)
plugin/logging_query/tests/t/update.test (+88/-0)
To merge this branch: bzr merge lp://qastaging/~sharan-monikantan/drizzle/trunk-bug-723915-complete
Reviewer Review Type Date Requested Status
Patrick Crews Needs Fixing
Review via email: mp+128547@code.qastaging.launchpad.net

Description of the change

Added tests for the logging query plugin

To post a comment you must log in.
Revision history for this message
Patrick Crews (patrick-crews) wrote :

Needs one bit of work in file.test:
The only issue is that the .result file contains the actual DRIZZLETEST_VARDIR value
This needs to be fixed either with disable_query_log to keep the output of the .result file (though echo output should indicate the action is being performed) or via the replace_result function to mask the actual DRIZZLETEST_VARDIR value (you'll need to capture it early in the test like:
actual_vardir_value = $DRIZZLETEST_VARDIR
...
--replace_result $actual_vardir_value DRIZZLETEST_VARDIR

replace_result would be preferable, but anything to eliminate the capture of a hard variable value in the .result file is good (so the test can run on anyone's machine regardless of where DRIZZLETEST_VARDIR may be)

=== modified file 'plugin/logging_query/tests/t/file.test'
--- plugin/logging_query/tests/t/file.test 2012-09-21 22:52:11 +0000
+++ plugin/logging_query/tests/t/file.test 2012-10-08 16:52:26 +0000
@@ -80,6 +80,11 @@
 --echo cleaning up...
 SET GLOBAL logging_query_enable=false;
 SET GLOBAL logging_query_pcre="*";
+# Here is where you either need to use:
+# disable_query_log, enable_query_log OR
+# replace_result from_val to_val [from_val to_val] ...
+# to capture what DRIZZLETEST_VARDIR really is and to mask it
+
 eval SET GLOBAL logging_query_filename="$DRIZZLETEST_VARDIR/logging_query.log";
 --exec rm $DRIZZLETEST_VARDIR/logging_query.log
 --echo ***done***

review: Needs Fixing

Unmerged revisions

2595. By Sharan Kumar

Added the following tests to logging_query plugin
1.blob
2.create
3.datatypes_datetime
4.datatypes_numeric
5.datatypes_string
6.delete
7.insert
8.select
9.update

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: