desktopcouch

Merge lp://qastaging/~sil/desktopcouch/dont-parse-all-the-changes into lp://qastaging/desktopcouch

  1. dont-parse-all-the-changes
  2. Merge into trunk
Proposed by Stuart Langridge
Status: Merged
Approved by: Chad Miller
Approved revision: 143
Merge reported by: Chad Miller
Merged at revision: not available
Proposed branch: lp://qastaging/~sil/desktopcouch/dont-parse-all-the-changes
Merge into: lp://qastaging/desktopcouch
Diff against target: 13 lines (+1/-4)
1 file modified
desktopcouch/records/server_base.py (+1/-4)
To merge this branch: bzr merge lp://qastaging/~sil/desktopcouch/dont-parse-all-the-changes
Reviewer Review Type Date Requested Status
Chad Miller (community) Approve
Eric Casteleijn (community) Approve
Review via email: mp+22414@code.qastaging.launchpad.net

Description of the change

Don't parse all the _changes feed; work out update_seq from the DB info, so we never request the whole feed, which is doom when the whole feed is large.

To post a comment you must log in.
Revision history for this message
Eric Casteleijn (thisfred) wrote :

Makes sense, looks good, tests pass.

review: Approve
Revision history for this message
Chad Miller (cmiller) wrote :

Thank you, sir.

review: Approve
Revision history for this message
Chad Miller (cmiller) wrote :

Really superceded, but tarmac hates this proposal for some reason that it refuses to tell.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches