address-book-app

Merge lp://qastaging/~sil2100/address-book-app/arm64_only_xenial into lp://qastaging/address-book-app

  1. arm64_only_xenial
  2. Merge into trunk
Proposed by Łukasz Zemczak
Status: Merged
Approved by: Renato Araujo Oliveira Filho
Approved revision: 614
Merged at revision: 614
Proposed branch: lp://qastaging/~sil2100/address-book-app/arm64_only_xenial
Merge into: lp://qastaging/address-book-app
Prerequisite: lp://qastaging/~sil2100/address-book-app/arm64_enable
Diff against target: 198 lines (+166/-0)
4 files modified
debian/bileto_pre_release_hook (+35/-0)
debian/control (+8/-0)
debian/control.in (+117/-0)
debian/rules (+6/-0)
To merge this branch: bzr merge lp://qastaging/~sil2100/address-book-app/arm64_only_xenial
Reviewer Review Type Date Requested Status
Ken VanDine packaging Approve
Renato Araujo Oliveira Filho (community) Approve
Review via email: mp+300627@code.qastaging.launchpad.net

Commit message

Add a temporary bileto_pre_release_hook that disables arm64 binary package builds for anything that's not xenial (LP: #1604869). Add the build-dependency of lsb-release for the use of the bileto hook.

Description of the change

Add a temporary bileto_pre_release_hook that disables arm64 binary package builds for anything that's not xenial (LP: #1604869).

To post a comment you must log in.
lp://qastaging/~sil2100/address-book-app/arm64_only_xenial updated
612. By Łukasz Zemczak

Add lsb-release as the build-dependency for bileto_pre_release_hook

613. By Łukasz Zemczak

Ommit the comment

Revision history for this message
Łukasz Zemczak (sil2100) wrote :

Ok, this was tested in a separate silo and works. Will add it to silo 004. This is now ready for review.

lp://qastaging/~sil2100/address-book-app/arm64_only_xenial updated
614. By Łukasz Zemczak

Modify the bileto hook to modify the arch list both sides.

Revision history for this message
Renato Araujo Oliveira Filho (renatofilho) wrote :

I am ok with with the changes. But I will leave the top approval for the packaging team.

review: Approve
lp://qastaging/~sil2100/address-book-app/arm64_only_xenial updated
615. By Łukasz Zemczak

Meh, the previous solution was too bad, using control.in will be good as well.

Revision history for this message
Ken VanDine (ken-vandine) wrote :

Packaging changes are fine

review: Approve (packaging)
lp://qastaging/~sil2100/address-book-app/arm64_only_xenial updated
616. By Łukasz Zemczak

Aaaaa debugging stuff removal I forgot.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches