Merge lp://qastaging/~sil2100/compiz-core/scale_all-0.9.7 into lp://qastaging/compiz-core
Status: | Merged |
---|---|
Approved by: | Daniel van Vugt |
Approved revision: | 3105 |
Merged at revision: | 3110 |
Proposed branch: | lp://qastaging/~sil2100/compiz-core/scale_all-0.9.7 |
Merge into: | lp://qastaging/compiz-core |
Diff against target: |
64 lines (+43/-0) 2 files modified
plugins/scale/src/privates.h (+2/-0) plugins/scale/src/scale.cpp (+41/-0) |
To merge this branch: | bzr merge lp://qastaging/~sil2100/compiz-core/scale_all-0.9.7 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Daniel van Vugt | Approve | ||
Sam Spilsbury | Approve | ||
Review via email:
|
Commit message
Add support for initiating window picker in other than nomal mode. For now added only the additional 'All windows' picker, essentially fixing LP: #933776.
The code from the all mode comes from a patch made by Doug McMahon. Thanks!
Description of the change
Submitting the fix first to 0.9.7 because I had the branch prepared and I want to go to sleep ASAP. But still, I would like some comment on this way of fixing the bug.
The scale plugin has many actions defined: initiate for current workspace, for all windows, for groups and for current output device. But the scale plugin only supports one handler for all actions (the type of the action is not considered at all). For now I added a distinction between ScaleTypeAll and ScaleTypeNormal. I took the code proposed by Doug in the bug report as the code for ScaleTypeAll.
Would be nice to have this SRUed.
I browsed through the commits, but I never really saw any type-distinct action code. But I might have missed that, since it's REALLY busy here in London!lp:~sil2100/compiz-core/scale_all-0.9.7
Will add the trunk version in the morning, if this one is alright.