Merge lp://qastaging/~sil2100/compiz/fix_770283 into lp://qastaging/~compiz/compiz/ubuntu

Proposed by Łukasz Zemczak
Status: Rejected
Rejected by: Sam Spilsbury
Proposed branch: lp://qastaging/~sil2100/compiz/fix_770283
Merge into: lp://qastaging/~compiz/compiz/ubuntu
Diff against target: 171 lines (+22/-124)
4 files modified
debian/changelog (+10/-0)
debian/patches/fix_770283.patch (+11/-0)
debian/patches/series (+1/-1)
debian/patches/workaround_770283.patch (+0/-123)
To merge this branch: bzr merge lp://qastaging/~sil2100/compiz/fix_770283
Reviewer Review Type Date Requested Status
Sam Spilsbury Needs Resubmitting
Didier Roche-Tolomelli Needs Fixing
Daniel van Vugt (community) Approve
Review via email: mp+102831@code.qastaging.launchpad.net

Commit message

The workaround for the fglrx problem is no longer needed (LP: #770283)! We have a real fix now.

Description of the change

The problem that is being fixed here is the fglrx LP: #770283 that's been causing so much trouble lately. We already got a dirty workaround merged as a distro patch, but just today we found the real cause! The driver is at fault here too, but not because of a bug, but an implementation difference. But because of this one-liner bug in compiz decor plugin, this implementation difference resulted in a nasty bug like this.

So, I'm recommending a fast remove of the workaround patch in regards of the ACTUAL REAL fix. I would like this to land in an SRU instead, if possible.

To post a comment you must log in.
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Yep, that's the one line fix we have accepted upstream.

review: Approve
779. By Łukasz Zemczak

Merged ogra's changes with the proposed MRQ

Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

The diff is wrong, you need an additional entry to the changelog.

review: Needs Fixing
780. By Łukasz Zemczak

Starting version 1:0.9.7.6-0ubuntu3.

Revision history for this message
Sam Spilsbury (smspillaz) wrote :

Fix is upstream now. Resubmit against packaging if required

review: Needs Resubmitting

Unmerged revisions

780. By Łukasz Zemczak

Starting version 1:0.9.7.6-0ubuntu3.

779. By Łukasz Zemczak

Merged ogra's changes with the proposed MRQ

778. By Łukasz Zemczak

The workaround for the fglrx problem is no longer needed! We have an actual fix now!

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: