Merge lp://qastaging/~sil2100/compiz/raring_revert_3616 into lp://qastaging/compiz/raring
Proposed by
Łukasz Zemczak
Status: | Merged |
---|---|
Approved by: | Didier Roche-Tolomelli |
Approved revision: | 3631 |
Merged at revision: | 3631 |
Proposed branch: | lp://qastaging/~sil2100/compiz/raring_revert_3616 |
Merge into: | lp://qastaging/compiz/raring |
Diff against target: |
19 lines (+1/-8) 1 file modified
plugins/decor/src/decor.cpp (+1/-8) |
To merge this branch: | bzr merge lp://qastaging/~sil2100/compiz/raring_revert_3616 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
PS Jenkins bot (community) | continuous-integration | Approve | |
Didier Roche-Tolomelli | Approve | ||
Review via email: mp+151897@code.qastaging.launchpad.net |
Commit message
Revert revision 3616, as the proposed fix causes serious regressions with Java Swing applications (LP: #1138517). That's no good!
To post a comment you must log in.
Might be better to actually look into this than hastily reverting.
Łukasz Zemczak has proposed merging lp:~sil2100/compiz/raring_revert_3616
into lp:compiz/raring.
Commit message:
Revert revision 3616, as the proposed fix causes serious regressions with
Java Swing applications (LP: #1138517). That's no good!
Requested reviews:
Compiz Maintainers (compiz-team)
For more details, see: /code.launchpad .net/~sil2100/ compiz/ raring_ revert_ 3616/+merge/ 151897
https:/
- Problem:
The fix introduced in 3616 (fix for LP: #1110138) introduces a serious
regression LP: #1138517.
- Fix:
Let's revert the fix for now, as it's better to have the earlier state than
broken Java Swing applications.
- Tests:
N/A /code.launchpad .net/~sil2100/ compiz/ raring_ revert_ 3616/+merge/ 151897
--
https:/
Your team Compiz Maintainers is requested to review the proposed merge of
lp:~sil2100/compiz/raring_revert_3616 into lp:compiz/raring.
=== modified file 'plugins/ decor/src/ decor.cpp' decor/src/ decor.cpp 2013-02-26 01:08:15 +0000 decor/src/ decor.cpp 2013-03-06 09:20:28 +0000 >xclient. window) ; uested flag so that we know to FRAME_EXTENTS (LP: #1110138) sRequested = true;
--- plugins/
+++ plugins/
@@ -2418,14 +2418,7 @@
{
w = screen->findWindow (event-
if (w)
- {
- DecorWindow *dw = DecorWindow::get (w);
-
- /* Set the frameExtentsReq
- * at least update _NET_WM_
*/
- dw->frameExtent
- dw->update (true);
- }
+ DecorWindow::get (w)->update (true);
}