Merge lp://qastaging/~sil2100/kubuntu-packaging/qtbase-opensource-src_5.0.2_qapp_fix into lp://qastaging/~kubuntu-packagers/kubuntu-packaging/qtbase-opensource-src_5.0.2

Proposed by Łukasz Zemczak
Status: Merged
Merge reported by: Timo Jyrinki
Merged at revision: not available
Proposed branch: lp://qastaging/~sil2100/kubuntu-packaging/qtbase-opensource-src_5.0.2_qapp_fix
Merge into: lp://qastaging/~kubuntu-packagers/kubuntu-packaging/qtbase-opensource-src_5.0.2
Diff against target: 26 lines (+14/-0)
2 files modified
debian/patches/fix_destroy_qapp_segfault.diff (+13/-0)
debian/patches/series (+1/-0)
To merge this branch: bzr merge lp://qastaging/~sil2100/kubuntu-packaging/qtbase-opensource-src_5.0.2_qapp_fix
Reviewer Review Type Date Requested Status
Timo Jyrinki Approve
Review via email: mp+204471@code.qastaging.launchpad.net

Commit message

Fix a segmentation fault bug in a strange case when a QWidget element (for instance, a QMenu element) gets freed (destroyed) after the main application exits and QApplication objects stops existing. Do not assume qApp will be present when cleaning memory. Fixes #1273306.

Description of the change

Fix a segmentation fault bug in a strange case when a QWidget element (for instance, a QMenu element) gets freed (destroyed) after the main application exits and QApplication objects stops existing. Do not assume qApp will be present when cleaning memory.

To post a comment you must log in.
Revision history for this message
Dmitry Shachnev (mitya57) wrote :

Is this fixed in 5.2? Or at least submitted upstream?

Revision history for this message
Timo Jyrinki (timo-jyrinki) wrote :

Yes, please find out the upstream situation and whether the patch needs to be proposed against trunk and backported to 5.2.0 as well.

review: Needs Fixing
Revision history for this message
Timo Jyrinki (timo-jyrinki) wrote :

Ok, it's in upstream trunk and also Qt 5.2 already, it's just that Łukasz found about the fix on his own.

review: Approve
Revision history for this message
Timo Jyrinki (timo-jyrinki) wrote :

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches