livecd-rootfs

Merge lp://qastaging/~sil2100/livecd-rootfs/rpi3-workarounds-hook into lp://qastaging/livecd-rootfs

  1. rpi3-workarounds-hook
  2. Merge into trunk
Proposed by Łukasz Zemczak
Status: Rejected
Rejected by: Steve Langasek
Proposed branch: lp://qastaging/~sil2100/livecd-rootfs/rpi3-workarounds-hook
Merge into: lp://qastaging/livecd-rootfs
Diff against target: 37 lines (+20/-1)
2 files modified
debian/changelog (+6/-1)
live-build/ubuntu-cpc/hooks.d/chroot/100-rpi3-workarounds.chroot (+14/-0)
To merge this branch: bzr merge lp://qastaging/~sil2100/livecd-rootfs/rpi3-workarounds-hook
Reviewer Review Type Date Requested Status
Michael Hudson-Doyle Needs Fixing
Steve Langasek Needs Resubmitting
Review via email: mp+360786@code.qastaging.launchpad.net

Commit message

Add Michael's rpi3 hax hook officially to the ubuntu-cpc images, but only executing it for raspi3 rootfs builds.

Description of the change

Add Michael's rpi3 hax hook officially to the ubuntu-cpc images, but only executing it for raspi3 rootfs builds.

So this is the first try on streamlining of the workarounds we need for raspi3 builds. The following could be also done as part of the existing hack for raspi2 we have in auto/config (where there's a config/hooks/999-raspi2-fixes.chroot created), but it felt to me just using the project-hook mechanism is cleaner.

Of course the best way would be to simply modify the seeds to not install grub-legacy-ec2 and install wpasupplicant, but not sure if we can do it per-subarch in there. I don't have enough knowledge to see if that's possible in any other sane way.

To post a comment you must log in.
Revision history for this message
Steve Langasek (vorlon) wrote :

today is the flag day for livecd-rootfs migration to git. Please resubmit as a git MP against lp:livecd-rootfs (the git one).

review: Needs Resubmitting
Revision history for this message
Steve Langasek (vorlon) :
Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :

So for disco, grub-legacy-ec2 is no longer in the server seed and we don't need that bit in devel (my understanding is that removing packages from a seed in a supported release isn't feasible so we will need it in bionic).

I don't think germinate knows anything about subarches indeed so we'll need something in livecd-rootfs to install wpasupplicant. But that would be cleaner done by calling add_package wpasupplicant around line 831 of auto/config I think?

IOW I more or less approve of this for bionic but think we can do better for devel :)

review: Needs Fixing
Revision history for this message
Łukasz Zemczak (sil2100) wrote :

+1 on going with the auto/config route. For bionic we'll change it a bit as well.

Unmerged revisions

1739. By Łukasz Zemczak

Add changelog

1738. By Łukasz Zemczak

Add Michael's rpi3 hax hook officially to the ubuntu-cpc images, but only executing it for raspi3 rootfs builds.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches