Merge lp://qastaging/~sil2100/ubuntu-release-upgrader/package-section-fix into lp://qastaging/ubuntu-release-upgrader
| Status: | Merged |
|---|---|
| Merged at revision: | 3294 |
| Proposed branch: | lp://qastaging/~sil2100/ubuntu-release-upgrader/package-section-fix |
| Merge into: | lp://qastaging/ubuntu-release-upgrader |
| Diff against target: |
31 lines (+4/-3) 1 file modified
DistUpgrade/DistUpgradeCache.py (+4/-3) |
| To merge this branch: | bzr merge lp://qastaging/~sil2100/ubuntu-release-upgrader/package-section-fix |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Julian Andres Klode | Approve | ||
| Brian Murray | Approve | ||
|
Review via email:
|
|||
Commit message
New python3-apt bindings no longer provide Package.section, so switch to using Package.
Description of the change
New python3-apt bindings no longer provide Package.section, so switch to using Package.
I have tested this on eoan by installing a package with lots of dependencies, removing it (leaving many unneeded packages) and additionally downgrading of some other package. Then I ran dist-upgrade.py --partial etc., first on the package as-is (reproducing the failure) and then with the changes applied. Seems to work as expected.
I guess Julian originally mentioned going through the list of versions (via Package.versions) to get the section match, but I think that's not needed here and Package.candidate is more than enough.
| Julian Andres Klode (juliank) | # |
| Łukasz Zemczak (sil2100) wrote | # |
| Julian Andres Klode (juliank) | # |
Thanks Julian! That indeed seems like a much safer bet.