Merge lp://qastaging/~sil2100/ubuntu-release-upgrader/snap-core18-from-stable into lp://qastaging/ubuntu-release-upgrader

Proposed by Łukasz Zemczak
Status: Merged
Merged at revision: 3281
Proposed branch: lp://qastaging/~sil2100/ubuntu-release-upgrader/snap-core18-from-stable
Merge into: lp://qastaging/ubuntu-release-upgrader
Prerequisite: lp://qastaging/~sil2100/ubuntu-release-upgrader/snap-size-estimation
Diff against target: 195 lines (+78/-34)
2 files modified
DistUpgrade/DistUpgradeQuirks.py (+15/-8)
tests/test_quirks.py (+63/-26)
To merge this branch: bzr merge lp://qastaging/~sil2100/ubuntu-release-upgrader/snap-core18-from-stable
Reviewer Review Type Date Requested Status
Brian Murray Approve
Review via email: mp+372082@code.qastaging.launchpad.net

Commit message

Make sure snaps like core18 are not refreshed/installed from the stable/ubuntu-VERSION branch but instead use stable on upgrades.

Description of the change

Make sure snaps like core18 are not refreshed/installed from the stable/ubuntu-VERSION branch but instead use stable on upgrades.

This branch depends on lp:~sil2100/ubuntu-release-upgrader/snap-size-estimation (and changes are included on top of it).

To post a comment you must log in.
3283. By Łukasz Zemczak

When checking for installed snaps, also use the right channel/branch.

Revision history for this message
Brian Murray (brian-murray) wrote :

This looks good other than changing a couple of variable names to make things consistent. Thanks for taking this on!

review: Approve
3284. By Łukasz Zemczak

Change variable naming.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches