Merge lp://qastaging/~sil2100/ubuntu-terminal-app/fix_cmake_revno into lp://qastaging/~ubuntu-terminal-dev/ubuntu-terminal-app/reboot
Proposed by
Łukasz Zemczak
| Status: | Merged |
|---|---|
| Merged at revision: | 46 |
| Proposed branch: | lp://qastaging/~sil2100/ubuntu-terminal-app/fix_cmake_revno |
| Merge into: | lp://qastaging/~ubuntu-terminal-dev/ubuntu-terminal-app/reboot |
| Diff against target: |
17 lines (+6/-1) 1 file modified
CMakeLists.txt (+6/-1) |
| To merge this branch: | bzr merge lp://qastaging/~sil2100/ubuntu-terminal-app/fix_cmake_revno |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Ubuntu Phone Apps Jenkins Bot | continuous-integration | Needs Fixing | |
| Alan Pope 🍺🐧🐱 🦄 (community) | Approve | ||
|
Review via email:
|
|||
Commit message
Don't use 'latest' as the BZR_REVNO as it is in no way a proper bzr revision number. Instead, use bzr revno to determine the correct rev as other click projects do.
Description of the change
Don't use 'latest' as the BZR_REVNO as it is in no way a proper bzr revision number. Instead, use bzr revno to determine the correct rev as other click projects do.
Please note that I have no experience in click builds and this solution has been simply copied over from other working core-app projects, so please double-test it before approval.
To post a comment you must log in.
Revision history for this message
| Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote | # |
review:
Needs Fixing
(continuous-integration)
Revision history for this message
| Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote | # |
review:
Needs Fixing
(continuous-integration)
Revision history for this message
| Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote | # |
review:
Needs Fixing
(continuous-integration)
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Thanks Łukasz!