webbrowser-app

Merge lp://qastaging/~sil2100/webbrowser-app/revert_pointing_to_mouse_conversion into lp://qastaging/webbrowser-app

  1. revert_pointing_to_mouse_conversion
  2. Merge into trunk
Proposed by Łukasz Zemczak
Status: Rejected
Rejected by: Łukasz Zemczak
Proposed branch: lp://qastaging/~sil2100/webbrowser-app/revert_pointing_to_mouse_conversion
Merge into: lp://qastaging/webbrowser-app
Diff against target: 296 lines (+67/-66)
2 files modified
debian/changelog (+1/-0)
tests/autopilot/webbrowser_app/tests/test_mainwindow.py (+66/-66)
To merge this branch: bzr merge lp://qastaging/~sil2100/webbrowser-app/revert_pointing_to_mouse_conversion
Reviewer Review Type Date Requested Status
Łukasz Zemczak Disapprove
Olivier Tilloy Needs Fixing
PS Jenkins bot continuous-integration Approve
Review via email: mp+161726@code.qastaging.launchpad.net

Commit message

Revert the pointing_device->mouse transition made by Robert, as well as fix the new test as well. This would be temporary until autopilot 1.3 is not ready

Description of the change

- Problem:

Recently Robert made a conversion from pointing_device to mouse to fix the autopilot tests failing on regular desktop autopilot. This was ok, but it then breaks the tests on actual touch devices, as there is no mouse device. So, we discussed this and decided that we should use pointing_device for now along with the autopilot-phablet version of the package until autopilot 1.3 is not ready. So, we need to revert the earlier changes.

- Fix:

Revert the pointing_device-to-mouse conversion. Also, convert newly added tests to use pointing_device as well.

- Tests:

N/A

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:122
http://jenkins.qa.ubuntu.com/job/webbrowser-app-ci/65/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-raring-amd64-ci/27
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-raring-armhf-ci/62
        deb: http://jenkins.qa.ubuntu.com/job/webbrowser-app-raring-armhf-ci/62/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-raring-i386-ci/62

Click here to trigger a rebuild:
http://s-jenkins:8080/job/webbrowser-app-ci/65/rebuild

review: Approve (continuous-integration)
Revision history for this message
Olivier Tilloy (osomon) wrote :

The autopilot tests have been refactored into several python modules, so this change needs to be updated (it currently conflicts when merging in trunk).

review: Needs Fixing
Revision history for this message
Łukasz Zemczak (sil2100) wrote :

No use in working on this one, as Omer has the 1.3-porting branches ready already. Best switch to 1.3 straight ahead.

review: Disapprove

Unmerged revisions

122. By Łukasz Zemczak

Add changelog entry

121. By Łukasz Zemczak

Revert the pointing_device->mouse transition made by Robert, as well as fix the new test as well

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to status/vote changes: