Landscape Charm

Merge lp://qastaging/~silverdrake11/landscape-charm/log_upgrade_version into lp://qastaging/landscape-charm

  1. log_upgrade_version
  2. Merge into ops-framework
Proposed by Kevin Nasto
Status: Merged
Merged at revision: 436
Proposed branch: lp://qastaging/~silverdrake11/landscape-charm/log_upgrade_version
Merge into: lp://qastaging/landscape-charm
Diff against target: 25 lines (+3/-1)
2 files modified
src/charm.py (+2/-0)
tests/test_charm.py (+1/-1)
To merge this branch: bzr merge lp://qastaging/~silverdrake11/landscape-charm/log_upgrade_version
Reviewer Review Type Date Requested Status
Mitch Burton Approve
Review via email: mp+438904@code.qastaging.launchpad.net

Commit message

Added landscape packages version in event upgrade action log

To post a comment you must log in.
Revision history for this message
Mitch Burton (mitchburton) wrote :

test failure:

======================================================================
FAIL: test_action_upgrade (tests.test_charm.TestCharm)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/perfect5th/Canonical/src/landscape-charm/log_upgrade_version/tests/test_charm.py", line 894, in test_action_upgrade
    self.assertEqual(event.log.call_count, 5)
AssertionError: 9 != 5

Otherwise LGTM

review: Needs Fixing
lp://qastaging/~silverdrake11/landscape-charm/log_upgrade_version updated
437. By Kevin Nasto

Fixed failing test

Revision history for this message
Kevin Nasto (silverdrake11) wrote :

> test failure:
>
> ======================================================================
> FAIL: test_action_upgrade (tests.test_charm.TestCharm)
> ----------------------------------------------------------------------
> Traceback (most recent call last):
> File "/home/perfect5th/Canonical/src/landscape-
> charm/log_upgrade_version/tests/test_charm.py", line 894, in
> test_action_upgrade
> self.assertEqual(event.log.call_count, 5)
> AssertionError: 9 != 5
>
> Otherwise LGTM

Fixed

Revision history for this message
Mitch Burton (mitchburton) wrote :

LGTM then

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: