Merge lp://qastaging/~simpoir/landscape-charm/1682105_revisit_config into lp://qastaging/~landscape/landscape-charm/trunk
Proposed by
Simon Poirier
| Status: | Merged | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Approved by: | Simon Poirier | ||||||||
| Approved revision: | 406 | ||||||||
| Merged at revision: | 408 | ||||||||
| Proposed branch: | lp://qastaging/~simpoir/landscape-charm/1682105_revisit_config | ||||||||
| Merge into: | lp://qastaging/~landscape/landscape-charm/trunk | ||||||||
| Diff against target: |
374 lines (+225/-21) 5 files modified
config.yaml (+23/-0) lib/callbacks/scripts.py (+43/-12) lib/callbacks/tests/test_scripts.py (+144/-7) lib/services.py (+7/-2) lib/tests/stubs.py (+8/-0) |
||||||||
| To merge this branch: | bzr merge lp://qastaging/~simpoir/landscape-charm/1682105_revisit_config | ||||||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| 🤖 Landscape Builder | test results | Approve | |
| Kevin Nasto | Approve | ||
|
Review via email:
|
|||
Commit message
Make proxy, system-email and root-url configurations updatable through the charm config.
Description of the change
Adds a few configuration to the charm.
Those were previously only updatable from the UI (proxy, system-email, root-url) or on bootstrap.
Requires changes which are fix-commited to landscape/trunk, for it to do anything.
Testing:
I have repackaged 19.10 with the trunk patch to actually be able to test this branch.
Trying to change those conf with the current 19.10 ppa will do nothing (the branch checks if the flag exists)
download https:/
juju deploy ./bundle.yml
juju config landscape-server system-
log to the ui, check the settings tab.
To post a comment you must log in.
Revision history for this message
| 🤖 Landscape Builder (landscape-builder) | # |
review:
Abstain
(executing tests)
Revision history for this message
| 🤖 Landscape Builder (landscape-builder) wrote | # |
review:
Needs Fixing
(test results)
Revision history for this message
| 🤖 Landscape Builder (landscape-builder) | # |
review:
Abstain
(executing tests)
Revision history for this message
| 🤖 Landscape Builder (landscape-builder) wrote | # |
review:
Approve
(test results)
Revision history for this message
| 🤖 Landscape Builder (landscape-builder) | # |
review:
Abstain
(executing tests)
Revision history for this message
| 🤖 Landscape Builder (landscape-builder) wrote | # |
review:
Approve
(test results)
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Command: make ci-test
Result: Fail
Revno: 404
Branch: lp:~simpoir/landscape-charm/1682105_revisit_config
Jenkins: https:/