Landscape Charm

Merge lp://qastaging/~simpoir/landscape-charm/bionic-source-build into lp://qastaging/~landscape/landscape-charm/trunk

  1. bionic-source-build
  2. Merge into trunk
Proposed by Simon Poirier
Status: Merged
Approved by: Simon Poirier
Approved revision: 394
Merged at revision: 391
Proposed branch: lp://qastaging/~simpoir/landscape-charm/bionic-source-build
Merge into: lp://qastaging/~landscape/landscape-charm/trunk
Diff against target: 82 lines (+17/-8)
3 files modified
lib/apt.py (+6/-2)
lib/tests/test_apt.py (+10/-6)
metadata.yaml (+1/-0)
To merge this branch: bzr merge lp://qastaging/~simpoir/landscape-charm/bionic-source-build
Reviewer Review Type Date Requested Status
Dave Jones (community) Approve
🤖 Landscape Builder test results Approve
Review via email: mp+349439@code.qastaging.launchpad.net

Commit message

Adds support for bionic.

Description of the change

Adds support for bionic.

Also sets local repo trusted for source installs, so it doesn't error on the unsigned repo.

Testing instructions.

# build source tarball since the PPA doesn't have bionic packages (yet)
cd landscape/trunk/standalone && make standalone-package-source
cp landscape-server_*.tar.gz path/to/this_charm/
juju deploy . --series bionic --config source="deb https://<redacted>@private-ppa.launchpad.net/landscape/lds-trunk/ubuntu bionic main" --config key=6E85A86E4652B4E6

juju debug-log # look for deployment errors

# feel free to also deploy and relate haproxy, postgresql and rabbitmq-server

To post a comment you must log in.
Revision history for this message
🤖 Landscape Builder (landscape-builder) :
review: Abstain (executing tests)
Revision history for this message
🤖 Landscape Builder (landscape-builder) wrote :

Command: make ci-test
Result: Fail
Revno: 393
Branch: lp:~simpoir/landscape-charm/bionic-source-build
Jenkins: https://ci.lscape.net/job/latch-test-xenial/3899/

review: Needs Fixing (test results)
lp://qastaging/~simpoir/landscape-charm/bionic-source-build updated
394. By Simon Poirier

lint

Revision history for this message
🤖 Landscape Builder (landscape-builder) :
review: Abstain (executing tests)
Revision history for this message
🤖 Landscape Builder (landscape-builder) wrote :

Command: make ci-test
Result: Success
Revno: 394
Branch: lp:~simpoir/landscape-charm/bionic-source-build
Jenkins: https://ci.lscape.net/job/latch-test-xenial/3900/

review: Approve (test results)
Revision history for this message
Dave Jones (waveform) wrote :

Deployment of charm went smoothly, as did deployment and relation of postgresql and rabbitmq-server. Hit a snag with haproxy though: deployed fine but fails to relate complaining it can't find an SSL cert:

unit-haproxy-1: 21:46:09 DEBUG unit.haproxy/1.reverseproxy-relation-changed [ALERT] 207/204609 (6354) : parsing [/etc/
haproxy/haproxy.cfg:59] : 'bind 0.0.0.0:443' : unable to load SSL certificate file '/var/lib/haproxy/default.pem' file
 does not exist.
unit-haproxy-1: 21:46:09 DEBUG unit.haproxy/1.reverseproxy-relation-changed [ALERT] 207/204609 (6354) : Parsing [/etc/
haproxy/haproxy.cfg:129]: frontend 'haproxy-1-80' has the same name as frontend 'haproxy-1-80' declared at /etc/haprox
y/haproxy.cfg:22.
unit-haproxy-1: 21:46:09 DEBUG unit.haproxy/1.reverseproxy-relation-changed [ALERT] 207/204609 (6354) : Error(s) found
 in configuration file : /etc/haproxy/haproxy.cfg
unit-haproxy-1: 21:46:09 DEBUG unit.haproxy/1.reverseproxy-relation-changed [ALERT] 207/204609 (6354) : Fatal errors f
ound in configuration.
unit-haproxy-1: 21:46:09 INFO unit.haproxy/1.juju-log reverseproxy:7: HAProxy configuration check failed, exiting.
unit-haproxy-1: 21:46:09 ERROR juju.worker.uniter.operation hook "reverseproxy-relation-changed" failed: exit status 1

I wonder if that's expected though; something the deployer is meant to provide?

Revision history for this message
Dave Jones (waveform) wrote :

Right, all looks good - SSL cert deployment is as expected; +1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches