Merge lp://qastaging/~simpoir/landscape-charm/pass_ping_through_https into lp://qastaging/~landscape/landscape-charm/trunk

Proposed by Simon Poirier
Status: Merged
Approved by: Simon Poirier
Approved revision: 402
Merged at revision: 402
Proposed branch: lp://qastaging/~simpoir/landscape-charm/pass_ping_through_https
Merge into: lp://qastaging/~landscape/landscape-charm/trunk
Diff against target: 60 lines (+9/-1)
2 files modified
lib/relations/haproxy.py (+2/-0)
lib/relations/tests/test_haproxy.py (+7/-1)
To merge this branch: bzr merge lp://qastaging/~simpoir/landscape-charm/pass_ping_through_https
Reviewer Review Type Date Requested Status
Daniel Manrique (community) Approve
🤖 Landscape Builder test results Approve
Review via email: mp+384051@code.qastaging.launchpad.net

Commit message

Add ping service to the https frontend in haproxy.

Description of the change

A few customers have strict no cleartext http policies.
Although not a security issue, the /ping endpoint was only exposed as http.

This branch changes that by also adding the backend to the https services
in haproxy, thus allowing that traffic to also go through https.

To post a comment you must log in.
Revision history for this message
🤖 Landscape Builder (landscape-builder) :
review: Abstain (executing tests)
Revision history for this message
🤖 Landscape Builder (landscape-builder) wrote :
review: Approve (test results)
Revision history for this message
Daniel Manrique (roadmr) wrote :

+1 thanks

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches