Merge lp://qastaging/~simpoir/landscape-client/fix_skipped_test_on_class_decorator into lp://qastaging/~landscape/landscape-client/trunk
Proposed by
Simon Poirier
| Status: | Merged |
|---|---|
| Approved by: | Simon Poirier |
| Approved revision: | 925 |
| Merged at revision: | 925 |
| Proposed branch: | lp://qastaging/~simpoir/landscape-client/fix_skipped_test_on_class_decorator |
| Merge into: | lp://qastaging/~landscape/landscape-client/trunk |
| Diff against target: |
495 lines (+66/-92) 1 file modified
landscape/tests/test_configuration.py (+66/-92) |
| To merge this branch: | bzr merge lp://qastaging/~simpoir/landscape-client/fix_skipped_test_on_class_decorator |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Данило Шеган (community) | Approve | ||
| Chad Smith | Approve | ||
| 🤖 Landscape Builder | test results | Approve | |
|
Review via email:
|
|||
Commit message
Re-enables (and fixes) tests that were shadowed by mock decorator on the TestCase class.
Description of the change
This branch re-enables (and fixes) tests that were shadowed by mock
decorator on a unittest class, unless trial was called explicitely with
the full test function names.
Testing instructions:
make check | grep ConfigurationFu
more specifically trial landscape.
should return 48 test successes instead instead of 0 previously.
To post a comment you must log in.
Revision history for this message
| 🤖 Landscape Builder (landscape-builder) | # |
review:
Abstain
(executing tests)
Revision history for this message
| 🤖 Landscape Builder (landscape-builder) wrote | # |
review:
Approve
(test results)
Revision history for this message
| Данило Шеган (danilo) | # |
review:
Approve
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Command: TRIAL_ARGS=-j4 make check
Result: Success
Revno: 925
Branch: lp:~simpoir/landscape-client/fix_skipped_test_on_class_decorator
Jenkins: https:/