Landscape Client

Merge lp://qastaging/~simpoir/landscape-client/mocker_to_mock_test_facade into lp://qastaging/~landscape/landscape-client/trunk

  1. mocker_to_mock_test_facade
  2. Merge into trunk
Proposed by Simon Poirier
Status: Merged
Approved by: Simon Poirier
Approved revision: 844
Merged at revision: 861
Proposed branch: lp://qastaging/~simpoir/landscape-client/mocker_to_mock_test_facade
Merge into: lp://qastaging/~landscape/landscape-client/trunk
Diff against target: 120 lines (+32/-32)
1 file modified
landscape/package/tests/test_facade.py (+32/-32)
To merge this branch: bzr merge lp://qastaging/~simpoir/landscape-client/mocker_to_mock_test_facade
Reviewer Review Type Date Requested Status
Bogdana Vereha (community) Approve
🤖 Landscape Builder test results Approve
Данило Шеган (community) Approve
Review via email: mp+297514@code.qastaging.launchpad.net

Commit message

This branches migrates to mock l/p/t/test_facade

Description of the change

This branches migrates to mock l/p/t/test_facade

Testing instructions:

run unit tests

To post a comment you must log in.
Revision history for this message
🤖 Landscape Builder (landscape-builder) :
review: Abstain (executing tests)
Revision history for this message
🤖 Landscape Builder (landscape-builder) wrote :

Command: make check
Result: Success
Revno: 843
Branch: lp:~simpoir/landscape-client/mocker_to_mock_test_facade
Jenkins: https://ci.lscape.net/job/latch-test/5041/

review: Approve (test results)
Revision history for this message
Данило Шеган (danilo) wrote :

You should make use of the wraps=os.dup2 in mock.patch("os.dup2") call. I've got a few other inline suggestions regarding naming.

review: Approve
Revision history for this message
Simon Poirier (simpoir) :
lp://qastaging/~simpoir/landscape-client/mocker_to_mock_test_facade updated
844. By Simon Poirier

address the comments of danilo

Revision history for this message
🤖 Landscape Builder (landscape-builder) :
review: Abstain (executing tests)
Revision history for this message
🤖 Landscape Builder (landscape-builder) wrote :

Command: make check
Result: Success
Revno: 844
Branch: lp:~simpoir/landscape-client/mocker_to_mock_test_facade
Jenkins: https://ci.lscape.net/job/latch-test/5052/

review: Approve (test results)
Revision history for this message
Bogdana Vereha (bogdana) wrote :

+1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: