Merge lp://qastaging/~simpoir/landscape-client/mocker_to_mock_test_load into lp://qastaging/~landscape/landscape-client/trunk

Proposed by Simon Poirier
Status: Merged
Approved by: Simon Poirier
Approved revision: 865
Merged at revision: 872
Proposed branch: lp://qastaging/~simpoir/landscape-client/mocker_to_mock_test_load
Merge into: lp://qastaging/~landscape/landscape-client/trunk
Diff against target: 26 lines (+5/-6)
1 file modified
landscape/sysinfo/tests/test_load.py (+5/-6)
To merge this branch: bzr merge lp://qastaging/~simpoir/landscape-client/mocker_to_mock_test_load
Reviewer Review Type Date Requested Status
🤖 Landscape Builder test results Approve
Free Ekanayaka (community) Approve
Bogdana Vereha (community) Approve
Review via email: mp+297547@code.qastaging.launchpad.net

Commit message

convert test_load to mock

Description of the change

convert test_load to mock

Testing instructions:

run unit tests

To post a comment you must log in.
Revision history for this message
Bogdana Vereha (bogdana) wrote :

+1 with a minor comment inline

review: Approve
Revision history for this message
🤖 Landscape Builder (landscape-builder) :
review: Abstain (executing tests)
Revision history for this message
🤖 Landscape Builder (landscape-builder) wrote :

Command: make check
Result: Success
Revno: 864
Branch: lp:~simpoir/landscape-client/mocker_to_mock_test_load
Jenkins: https://ci.lscape.net/job/latch-test/5056/

review: Approve (test results)
Revision history for this message
Free Ekanayaka (free.ekanayaka) wrote :

+1

review: Approve
865. By Simon Poirier

address comments

Revision history for this message
🤖 Landscape Builder (landscape-builder) :
review: Abstain (executing tests)
Revision history for this message
🤖 Landscape Builder (landscape-builder) wrote :

Command: make check
Result: Success
Revno: 865
Branch: lp:~simpoir/landscape-client/mocker_to_mock_test_load
Jenkins: https://ci.lscape.net/job/latch-test/5065/

review: Approve (test results)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: