Landscape Client

Merge lp://qastaging/~simpoir/landscape-client/mocker_to_mock_test_registration into lp://qastaging/~landscape/landscape-client/trunk

  1. mocker_to_mock_test_registration
  2. Merge into trunk
Proposed by Simon Poirier
Status: Merged
Approved by: Simon Poirier
Approved revision: 877
Merged at revision: 894
Proposed branch: lp://qastaging/~simpoir/landscape-client/mocker_to_mock_test_registration
Merge into: lp://qastaging/~landscape/landscape-client/trunk
Diff against target: 184 lines (+26/-42)
1 file modified
landscape/broker/tests/test_registration.py (+26/-42)
To merge this branch: bzr merge lp://qastaging/~simpoir/landscape-client/mocker_to_mock_test_registration
Reviewer Review Type Date Requested Status
Benji York (community) Approve
🤖 Landscape Builder test results Approve
Chris Glass (community) Approve
Review via email: mp+297651@code.qastaging.launchpad.net

Commit message

mock-ifies l/b/t/test_registration.py

Description of the change

mock-ifies l/b/t/test_registration.py

Testing instructions:

To post a comment you must log in.
Revision history for this message
🤖 Landscape Builder (landscape-builder) :
review: Abstain (executing tests)
Revision history for this message
Chris Glass (tribaal) wrote :

+1!

Couple of non-blocking nits inline

review: Approve
Revision history for this message
Simon Poirier (simpoir) :
Revision history for this message
🤖 Landscape Builder (landscape-builder) wrote :

Command: TRIAL_ARGS=-j4 make check
Result: Fail
Revno: 877
Branch: lp:~simpoir/landscape-client/mocker_to_mock_test_registration
Jenkins: https://ci.lscape.net/job/latch-test/5097/

review: Needs Fixing (test results)
Revision history for this message
🤖 Landscape Builder (landscape-builder) :
review: Abstain (executing tests)
Revision history for this message
🤖 Landscape Builder (landscape-builder) wrote :

Command: TRIAL_ARGS=-j4 make check
Result: Success
Revno: 877
Branch: lp:~simpoir/landscape-client/mocker_to_mock_test_registration
Jenkins: https://ci.lscape.net/job/latch-test/5102/

review: Approve (test results)
Revision history for this message
Benji York (benji) wrote :

Looks good.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: