Merge lp://qastaging/~sj26/terminator/gtk3-dark-setting into lp://qastaging/terminator/gtk3

Proposed by Samuel Cochran
Status: Needs review
Proposed branch: lp://qastaging/~sj26/terminator/gtk3-dark-setting
Merge into: lp://qastaging/terminator/gtk3
Diff against target: 153 lines (+38/-9)
4 files modified
terminatorlib/config.py (+1/-0)
terminatorlib/preferences.glade (+25/-8)
terminatorlib/prefseditor.py (+8/-0)
terminatorlib/terminator.py (+4/-1)
To merge this branch: bzr merge lp://qastaging/~sj26/terminator/gtk3-dark-setting
Reviewer Review Type Date Requested Status
Terminator Pending
Review via email: mp+319665@code.qastaging.launchpad.net

Description of the change

Add dark theme setting for Terminator running under GTK3 similar to GNOME Terminal.

I love the ability to switch GNOME Terminal into the theme's Dark variant mode. Turns out it's just a gtk settings property which can be toggle pretty easily:

https://git.gnome.org/browse/gnome-terminal/tree/src/terminal-app.c#n317

This branch adds a new checkbox to the preference panel under Appearance for "Dark Theme" which defaults to false.

Here are some screenshots:

http://imgur.com/gallery/gbWwW

To post a comment you must log in.

Unmerged revisions

1757. By Samuel Cochran

Dark theme setting

Add a dark theme setting equivalent to GNOME Terminal.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to status/vote changes: