Compiz

Merge lp://qastaging/~sjakthol/compiz/fix-438580 into lp://qastaging/compiz/0.9.10

  1. fix-438580
  2. Merge into 0.9.10
Proposed by Sami Jaktholm
Status: Merged
Approved by: MC Return
Approved revision: 3754
Merged at revision: 3757
Proposed branch: lp://qastaging/~sjakthol/compiz/fix-438580
Merge into: lp://qastaging/compiz/0.9.10
Diff against target: 14 lines (+2/-2)
1 file modified
plugins/expo/src/expo.cpp (+2/-2)
To merge this branch: bzr merge lp://qastaging/~sjakthol/compiz/fix-438580
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
MC Return Approve
Review via email: mp+173345@code.qastaging.launchpad.net

Commit message

Expo: Cast denominators of integer divisions to floats before performing a
      matrix translation to viewports with the results. Otherwise rounding
      errors in cases the results are not an integers cause the viewports to
      be painted offscreen.

Description of the change

Before: https://launchpadlibrarian.net/65497351/compiz_twinview_expo_bug.png
After: http://i.imgur.com/PodFZ5y.png

Please note that I have only been able to test this in a VM so some real world testing would be good. This is a fairly obvious change though so I don't think it's going to cause any issues.

To post a comment you must log in.
Revision history for this message
MC Return (mc-return) wrote :

Hey. :)
"Can it really be that simple ?", I sometimes ask myself ;)

+1 for this one. Great !
I will test this on bare metal to make sure, but I think I can approve this immediately !

review: Approve
Revision history for this message
MC Return (mc-return) wrote :

Bug number 438580 is really cool also: Reported on 2009-09-29 -> Quite oldschool :)

Finally fixed after years -> we should increase priority of such old bugs each year ;)

Revision history for this message
MC Return (mc-return) wrote :

Sami, are you interested in becoming a Compiz maintainer ?
IMHO with all the things you've already done, you deserve full rights in the Compiz project. :)

review: Needs Information
Revision history for this message
Sami Jaktholm (sjakthol) wrote :

Thanks but no thanks. I'd rather not become too much involved with compiz. I just like to occasionally hack on it...

Revision history for this message
MC Return (mc-return) wrote :

Sure. Np. :)
Your "hacks" are always appreciated. :)

Revision history for this message
MC Return (mc-return) wrote :

Andyrock told me trunk is unblocked, so this can still make it to 0.9.10.0 it seems. :)

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches