Merge lp://qastaging/~smoser/charm-helpers/apt-install-noninteractive into lp://qastaging/charm-helpers
Proposed by
Scott Moser
| Status: | Merged |
|---|---|
| Merged at revision: | 96 |
| Proposed branch: | lp://qastaging/~smoser/charm-helpers/apt-install-noninteractive |
| Merge into: | lp://qastaging/charm-helpers |
| Diff against target: |
153 lines (+44/-16) 2 files modified
charmhelpers/fetch/__init__.py (+12/-5) tests/fetch/test_fetch.py (+32/-11) |
| To merge this branch: | bzr merge lp://qastaging/~smoser/charm-helpers/apt-install-noninteractive |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| James Page | Approve | ||
| Michael Nelson | Approve | ||
|
Review via email:
|
|||
Commit message
Changes to 'install' to ensure non-interactive mode
This makes 2 changes to invocations of 'apt-get install'
a.) adds DEBIAN_
b.) uses options --option=
Also changed:
* change '-y' to '--assume-yes' for readability.
* changes to tests to accommodate
Description of the change
Changes to 'install' to ensure non-interactive mode
This makes 2 changes to invocations of 'apt-get install'
a.) adds DEBIAN_
b.) uses options --option=
Also changed:
* change '-y' to '--assume-yes' for readability.
* changes to tests to accommodate
To post a comment you must log in.
Revision history for this message
| James Page (james-page) | # |
review:
Approve
Revision history for this message
| Scott Moser (smoser) wrote | # |
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Excellent - thanks Scott. Out of interest, without the two extra options, in what situations were you seeing interactive mode?
Also, can we swap reviews? :-)
https:/
Most of the diff is moving a chunk of code to a more shareable location.