Merge lp://qastaging/~smoser/curtin/trunk.run-in-chroot-revival into lp://qastaging/~curtin-dev/curtin/trunk

Proposed by Scott Moser
Status: Merged
Merged at revision: 422
Proposed branch: lp://qastaging/~smoser/curtin/trunk.run-in-chroot-revival
Merge into: lp://qastaging/~curtin-dev/curtin/trunk
Diff against target: 65 lines (+41/-0)
2 files modified
curtin/util.py (+10/-0)
tests/unittests/test_util.py (+31/-0)
To merge this branch: bzr merge lp://qastaging/~smoser/curtin/trunk.run-in-chroot-revival
Reviewer Review Type Date Requested Status
Ryan Harper (community) Approve
Server Team CI bot continuous-integration Approve
Review via email: mp+304271@code.qastaging.launchpad.net

Commit message

add support for RunInChroot in curtin.util

In my merge committed to trunk in revno 404, we dropped 'RunInChroot'.
That method was being used from curthooks in maas-images project to
make a chrootable target. In order to support installation of old images
that depend on RunInChroot we need to add the method back.

This does that by just utilizing ChrootableTarget. It also adds
a couple unit tests to ensure that this keeps working.

To post a comment you must log in.
422. By Scott Moser

fix tox, remove 'print'

Revision history for this message
Server Team CI bot (server-team-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Ryan Harper (raharper) :
Revision history for this message
Scott Moser (smoser) wrote :

To address your concerns about subp tests, I added some more here.
https://code.launchpad.net/~smoser/curtin/trunk.subp-more-tests/+merge/304297

Revision history for this message
Ryan Harper (raharper) wrote :

Additional tests look good. We can merge this and those after.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches