Compiz Animations Plugin

Merge lp://qastaging/~smspillaz/compiz-animation-plugin/compiz-animation-plugin.fix_976469 into lp://qastaging/compiz-animation-plugin

  1. compiz-animation-plugin.fix_976469
  2. Merge into 0.9.5
Proposed by Sam Spilsbury
Status: Merged
Merged at revision: 396
Proposed branch: lp://qastaging/~smspillaz/compiz-animation-plugin/compiz-animation-plugin.fix_976469
Merge into: lp://qastaging/compiz-animation-plugin
Diff against target: 181 lines (+19/-8)
8 files modified
include/animation/animeffect.h (+2/-0)
include/animation/fade.h (+1/-0)
include/animation/grid.h (+2/-0)
include/animation/gridtransform.h (+1/-0)
include/animation/transform.h (+1/-0)
include/animation/zoom.h (+2/-0)
src/animation.cpp (+3/-8)
src/private.h (+7/-0)
To merge this branch: bzr merge lp://qastaging/~smspillaz/compiz-animation-plugin/compiz-animation-plugin.fix_976469
Reviewer Review Type Date Requested Status
Daniel van Vugt Approve
Review via email: mp+101334@code.qastaging.launchpad.net

This proposal supersedes a proposal from 2012-04-08.

Description of the change

== Problem ==

The animation plugin was setting PAINT_WINDOW_TRANSFORMED_MASK even when it didn't need it, which would confuse other plugins

== Solution ==

Added a vfunc to determine whether or not we actually need to do that

Fixes LP#976469

To post a comment you must log in.
Revision history for this message
Daniel van Vugt (vanvugt) wrote : Posted in a previous version of this proposal

First observation: requiresTransformedWindow() should be const.

Revision history for this message
Daniel van Vugt (vanvugt) wrote : Posted in a previous version of this proposal

Tests OK. No obvious regressions, though I also don't see any shadows being clipped at all.

review: Approve
Revision history for this message
Daniel van Vugt (vanvugt) wrote : Posted in a previous version of this proposal

Hmm, I will approve this again, but first please:

1. Remove " // TODO: should only happen for distorting effects"
2. Consider making requiresTransformedWindow() const.

review: Needs Fixing
Revision history for this message
Daniel van Vugt (vanvugt) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches