Merge lp://qastaging/~smspillaz/compiz-core/compiz-core.fix_888704 into lp://qastaging/compiz-core

Proposed by Sam Spilsbury
Status: Merged
Merged at revision: 3076
Proposed branch: lp://qastaging/~smspillaz/compiz-core/compiz-core.fix_888704
Merge into: lp://qastaging/compiz-core
Diff against target: 115 lines (+42/-23)
3 files modified
CMakeLists.txt (+24/-0)
src/screen.cpp (+17/-1)
src/window.cpp (+1/-22)
To merge this branch: bzr merge lp://qastaging/~smspillaz/compiz-core/compiz-core.fix_888704
Reviewer Review Type Date Requested Status
Daniel van Vugt Approve
Alan Griffiths Needs Fixing
Review via email: mp+99470@code.qastaging.launchpad.net

Description of the change

== Problem ==

See LP#888704 - a window that was raised but not focused with alt-tab would not have the focus returned to it once the preceeding window was closed

== Solution ==

Restore focus based on stacking order in the non click raise case.

To post a comment you must log in.
Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

Should not be a line continuation here:

CompWindow *nextActive = screen->findWindow (screen->priv->nextActiveWindow);\

review: Needs Fixing
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

No obvious problems in testing. And I can fix the aforementioned typo when I merge.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches