Merge lp://qastaging/~smspillaz/compiz-core/compiz-core.fix_891591 into lp://qastaging/compiz-core/0.9.5
Proposed by
Sam Spilsbury
Status: | Merged |
---|---|
Approved by: | Daniel van Vugt |
Approved revision: | 2942 |
Merged at revision: | 2911 |
Proposed branch: | lp://qastaging/~smspillaz/compiz-core/compiz-core.fix_891591 |
Merge into: | lp://qastaging/compiz-core/0.9.5 |
Prerequisite: | lp://qastaging/~smspillaz/compiz-core/compiz-core.fix_894688 |
Diff against target: |
20 lines (+1/-2) 1 file modified
src/screen.cpp (+1/-2) |
To merge this branch: | bzr merge lp://qastaging/~smspillaz/compiz-core/compiz-core.fix_891591 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Daniel van Vugt | Approve | ||
Review via email: mp+88492@code.qastaging.launchpad.net |
This proposal supersedes a proposal from 2011-12-01.
Description of the change
Mark screen as initialized before initializing windows as windowInitPlugins
may implicitly call the constructor of a PluginScreen and likely PluginOptions
which will try to register actions and will silently fail
eg,
windowInitP
PluginScree
CompScreen:
This should fix bug 896591
To post a comment you must log in.
I don't need to fully understand this code to say:
1. The change to src/window.cpp looks like a mistake so should be removed.
2. Are you sure this proposal fixes bug 891591? Or is that a typo and its meant to fix a different bug?