Merge lp://qastaging/~smspillaz/compiz-core/compiz-core.fix_924736.2 into lp://qastaging/compiz-core
Status: | Rejected |
---|---|
Rejected by: | Sam Spilsbury |
Proposed branch: | lp://qastaging/~smspillaz/compiz-core/compiz-core.fix_924736.2 |
Merge into: | lp://qastaging/compiz-core |
Diff against target: |
122 lines (+50/-7) 4 files modified
gtk/window-decorator/decorator.c (+1/-1) gtk/window-decorator/events.c (+4/-0) gtk/window-decorator/settings.c (+10/-3) plugins/decor/src/decor.cpp (+35/-3) |
To merge this branch: | bzr merge lp://qastaging/~smspillaz/compiz-core/compiz-core.fix_924736.2 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Daniel van Vugt | Needs Fixing | ||
Review via email: mp+92727@code.qastaging.launchpad.net |
Description of the change
Only clip shadows based on windows underneath and only clip if the window is adjacent
and not overlapping (this way you can have two semi maximized windows right next to each
other and not have them cast shadows)
Also update the window decoration state and actions when the window is redecorated
Fix typo that would cause active maximized windows to not get shadows
Unmerged revisions
- 2999. By Sam Spilsbury
-
Use a default value for the draggable border width if the mutter key doesn't exist
- 2998. By Sam Spilsbury
-
Only clip shadows based on windows underneath and only clip if the window is adjacent
and not overlapping (this way you can have two semi maximized windows right next to each
other and not have them cast shadows)Also update the window decoration state and actions when the
window is redecoratedFix typo that would cause active maximized windows to not get shadows
Fixes LP #924736
The shadows seem fixed. However the window borders are still lost when semi-maximized as described in the bug;
"Semi-maximized windows also seem to not have any border (as if they think they are fully maximized)."