Merge lp://qastaging/~smspillaz/compiz-core/compiz-core.fix_944631 into lp://qastaging/compiz-core

Proposed by Sam Spilsbury
Status: Merged
Merged at revision: 3038
Proposed branch: lp://qastaging/~smspillaz/compiz-core/compiz-core.fix_944631
Merge into: lp://qastaging/compiz-core
Diff against target: 69 lines (+16/-6)
1 file modified
src/event.cpp (+16/-6)
To merge this branch: bzr merge lp://qastaging/~smspillaz/compiz-core/compiz-core.fix_944631
Reviewer Review Type Date Requested Status
Daniel van Vugt Approve
Review via email: mp+95517@code.qastaging.launchpad.net

Description of the change

== Problem ==

Pressing alt-left-right would trigger alt-tab

== Solution ==

Don't trigger keybindings which aren't active

== Tests ==

None yet.

To post a comment you must log in.
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

I think this is actually bug 943612.

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

I will test this on the weekend or Monday.

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Tests OK.

I note however:
1. A tab change on line 31.
2. I'm not convinced that chunk @@ -1050,8 +1055,11 @@ is necessary.
3. I'm fairly sure that chunk @@ -1062,6 +1070,8 @@ is redundant because XFlush is already called as soon as alwaysHandleEvent returns.

But these are not blocking issues.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches