Compiz Core

Merge lp://qastaging/~smspillaz/compiz-core/compiz-core.fix_944631 into lp://qastaging/compiz-core

compiz-core.fix_944631
Merge into 0.9.7

Proposed by Sam Spilsbury on 2012-03-02

Status:	Merged
Merged at revision:	3038
Proposed branch:	lp://qastaging/~smspillaz/compiz-core/compiz-core.fix_944631
Merge into:	lp://qastaging/compiz-core
Diff against target:	69 lines (+16/-6) 1 file modified src/event.cpp (+16/-6)
To merge this branch:	bzr merge lp://qastaging/~smspillaz/compiz-core/compiz-core.fix_944631
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Daniel van Vugt		2012-03-02	Approve on 2012-03-04
Review via email: mp+95517@code.qastaging.launchpad.net

Description of the change

== Problem ==

Pressing alt-left-right would trigger alt-tab

== Solution ==

Don't trigger keybindings which aren't active

== Tests ==

None yet.

Revision history for this message

Daniel van Vugt (vanvugt) wrote on 2012-03-02:

I think this is actually bug 943612.

Revision history for this message

Daniel van Vugt (vanvugt) wrote on 2012-03-02:

I will test this on the weekend or Monday.

Revision history for this message

Daniel van Vugt (vanvugt) wrote on 2012-03-04:

Tests OK.

I note however:
1. A tab change on line 31.
2. I'm not convinced that chunk @@ -1050,8 +1055,11 @@ is necessary.
3. I'm fairly sure that chunk @@ -1062,6 +1070,8 @@ is redundant because XFlush is already called as soon as alwaysHandleEvent returns.

But these are not blocking issues.

review: Approve