Code review comment for lp://qastaging/~smspillaz/compiz-core/compiz-core.fix_944631

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Tests OK.

I note however:
1. A tab change on line 31.
2. I'm not convinced that chunk @@ -1050,8 +1055,11 @@ is necessary.
3. I'm fairly sure that chunk @@ -1062,6 +1070,8 @@ is redundant because XFlush is already called as soon as alwaysHandleEvent returns.

But these are not blocking issues.

review: Approve

« Back to merge proposal