Merge lp://qastaging/~smspillaz/compiz-core/compiz-core.width-height-for-border into lp://qastaging/compiz-core

Proposed by Sam Spilsbury
Status: Rejected
Rejected by: Sam Spilsbury
Proposed branch: lp://qastaging/~smspillaz/compiz-core/compiz-core.width-height-for-border
Merge into: lp://qastaging/compiz-core
Prerequisite: lp://qastaging/~smspillaz/compiz-core/compiz-core.work_923683
Diff against target: 383 lines (+81/-80)
9 files modified
plugins/decor/src/decor.cpp (+4/-6)
plugins/move/src/move.cpp (+2/-4)
plugins/place/src/constrain-to-workarea/src/constrain-to-workarea.cpp (+4/-6)
plugins/place/src/place.cpp (+19/-24)
src/screen.cpp (+2/-2)
src/window.cpp (+10/-10)
src/window/geometry/include/core/windowgeometry.h (+6/-0)
src/window/geometry/tests/window-geometry/src/test-window-geometry.cpp (+10/-0)
src/windowgeometry.cpp (+24/-28)
To merge this branch: bzr merge lp://qastaging/~smspillaz/compiz-core/compiz-core.width-height-for-border
Reviewer Review Type Date Requested Status
Compiz Maintainers Pending
Review via email: mp+100728@code.qastaging.launchpad.net

Description of the change

Adds widthIncBorders heightIncBorders etc to window::Geometry as suggested by alan at https://code.launchpad.net/~smspillaz/compiz-core/compiz-core.work_923683/+merge/100543/comments/216930

To post a comment you must log in.
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

I think it would make sense to merge this branch into its prerequisite, perhaps.

Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

> I think it would make sense to merge this branch into its prerequisite,
> perhaps.

+1

Unmerged revisions

2996. By Sam Spilsbury

Removed a lot of width () / height () + border () * 2 sillyness, replace with
more sturdy abstraction

2995. By Sam Spilsbury

Merge trunk

2994. By Sam Spilsbury

Use reference

2993. By Sam Spilsbury

Merge lp:compiz-core

2992. By Sam Spilsbury

Fix silly typo

2991. By Sam Spilsbury

Cleanup, fix removal of XSynchronize and detect error conditions

2990. By Sam Spilsbury

Also send moveNotify for override redirect windows

2989. By Sam Spilsbury

Added a note for a fixme

2988. By Sam Spilsbury

Also adjust the client position inside the frame whenever the frame value mask
indicates that it might have moved.

2987. By Sam Spilsbury

Update PrivateWindow::isInvisible

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches