Code review comment for lp://qastaging/~smspillaz/compiz-core/fix-timer-warnings-893998

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

As per the previous version of this proposal... Looks good, but:

1. Line 17 looks like it will conflict with my existing merge proposal:
https://code.launchpad.net/~vanvugt/compiz-core/bettertimers/+merge/82812
It's only a blank line so should not be hard to resolve.

2. Why prerequisite fix-893467 when it does not seem to be required? This fix alone appears to resolve bug 893998.

review: Needs Information

« Back to merge proposal