Merge lp://qastaging/~smspillaz/compiz-libcompizconfig/compiz-libcompizconfig.refactor-plugin into lp://qastaging/~compiz-team/compiz-libcompizconfig/0.9.8

Proposed by Sam Spilsbury
Status: Superseded
Proposed branch: lp://qastaging/~smspillaz/compiz-libcompizconfig/compiz-libcompizconfig.refactor-plugin
Merge into: lp://qastaging/~compiz-team/compiz-libcompizconfig/0.9.8
Prerequisite: lp://qastaging/~smspillaz/compiz-libcompizconfig/compiz-libcompizconfig.context-funcs-behind-interface
Diff against target: 1314 lines (+324/-196)
6 files modified
backend/src/ini.c (+23/-23)
include/ccs.h (+20/-25)
plugin/ccp/src/ccp.cpp (+3/-3)
src/ccs-private.h (+25/-0)
src/compiz.cpp (+61/-57)
src/main.c (+192/-88)
To merge this branch: bzr merge lp://qastaging/~smspillaz/compiz-libcompizconfig/compiz-libcompizconfig.refactor-plugin
Reviewer Review Type Date Requested Status
Compiz Maintainers Pending
Review via email: mp+103996@code.qastaging.launchpad.net

This proposal has been superseded by a proposal from 2012-04-29.

Description of the change

This is all about bug 990690.

!! - It probably isn't a good idea to test this branch in isolation, as it is part of a pipeline to get compiz-libcompizconfig under test. If you want to test the result of this work, you should probably look at testing

lp:~smspillaz/compiz-libcompizconfig/compiz-libcompizconfig.mock-context
lp:~smspillaz/compiz-compizconfig-python/compiz-compizconfig-python.setting-api
lp:~smspillaz/compiz-compizconfig-gconf/compiz-compizconfig-gconf.adapt-to-new-interfaces

.. that's all !!

This branch takes all of the public members of the plugin struct and hides them behind a private pointer requiring indirection to access them

To post a comment you must log in.

Unmerged revisions

442. By Sam Spilsbury

Merged context-funcs-behind-interface into refactor-plugin.

441. By Sam Spilsbury

Merged context-funcs-behind-interface into refactor-plugin.

440. By Sam Spilsbury

Merged context-funcs-behind-interface into refactor-plugin.

439. By Sam Spilsbury

Merged context-funcs-behind-interface into refactor-plugin.

438. By Sam Spilsbury

Merged context-funcs-behind-interface into refactor-plugin.

437. By Sam Spilsbury

Work correctly with protocol buffers

436. By Sam Spilsbury

Merged context-funcs-behind-interface into refactor-plugin.

435. By Sam Spilsbury

Bindability

434. By Sam Spilsbury

Hide details of CCSPlugin in priv, provide accesor functions

433. By Sam Spilsbury

Hide the private stuff behind the interface too

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches