Compiz

Merge lp://qastaging/~smspillaz/compiz/compiz.animationsjc-returns-v2 into lp://qastaging/compiz/0.9.13

  1. compiz.animationsjc-returns-v2
  2. Merge into 0.9.13
Proposed by Sam Spilsbury
Status: Merged
Approved by: Marco Trevisan (Treviño)
Approved revision: 4073
Merged at revision: 4072
Proposed branch: lp://qastaging/~smspillaz/compiz/compiz.animationsjc-returns-v2
Merge into: lp://qastaging/compiz/0.9.13
Diff against target: 1121 lines (+1019/-0)
15 files modified
debian/compiz-dev.install (+1/-0)
debian/compiz-plugins.install (+2/-0)
debian/compiz-plugins.install.armel (+2/-0)
debian/compiz-plugins.install.armhf (+2/-0)
plugins/animationjc/CMakeLists.txt (+4/-0)
plugins/animationjc/animationjc.xml.in (+154/-0)
plugins/animationjc/compiz-animationjc.pc.in (+12/-0)
plugins/animationjc/include/animationjc/animationjc.h (+42/-0)
plugins/animationjc/src/animationjc.cpp (+150/-0)
plugins/animationjc/src/blackhole.cpp (+79/-0)
plugins/animationjc/src/flicker.cpp (+96/-0)
plugins/animationjc/src/ghost.cpp (+98/-0)
plugins/animationjc/src/popcorn.cpp (+60/-0)
plugins/animationjc/src/private.h (+232/-0)
plugins/animationjc/src/raindrop.cpp (+85/-0)
To merge this branch: bzr merge lp://qastaging/~smspillaz/compiz/compiz.animationsjc-returns-v2
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Pending
Marco Trevisan (Treviño) Pending
Review via email: mp+301092@code.qastaging.launchpad.net

This proposal supersedes a proposal from 2016-07-09.

Commit message

Re-add the animationsjc plugin

Description of the change

Re-add the animationsjc plugin.

Removed dependency on libGLU.

(Thanks to MC Return for preserving this)

To post a comment you must log in.
Revision history for this message
Marco Trevisan (Treviño) (3v1n0) wrote : Posted in a previous version of this proposal

Please add .pc file to -dev:

dh_install: usr/lib/x86_64-linux-gnu/pkgconfig/compiz-animationjc.pc exists in debian/tmp but is not installed to anywhere

review: Needs Fixing
Revision history for this message
Sam Spilsbury (smspillaz) wrote : Posted in a previous version of this proposal

Of course. I'm not sure why animationjc installs a pkgconfig file - I don't think it purports to actually export and extension plugin. Nevertheless, probably better to just install it.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches