Merge lp://qastaging/~smspillaz/unity/unity.fix_838062 into lp://qastaging/unity
Status: | Merged | ||||
---|---|---|---|---|---|
Merged at revision: | 1479 | ||||
Proposed branch: | lp://qastaging/~smspillaz/unity/unity.fix_838062 | ||||
Merge into: | lp://qastaging/unity | ||||
Diff against target: |
277 lines (+130/-5) 5 files modified
plugins/unityshell/src/compizminimizedwindowhandler.h (+71/-0) plugins/unityshell/src/inputremover.cpp (+35/-5) plugins/unityshell/src/inputremover.h (+4/-0) plugins/unityshell/src/unityshell.cpp (+18/-0) plugins/unityshell/src/unityshell.h (+2/-0) |
||||
To merge this branch: | bzr merge lp://qastaging/~smspillaz/unity/unity.fix_838062 | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Jason Smith (community) | Approve | ||
Review via email:
|
Description of the change
Fixes a number of cases where the input shape could be restored while the window is minimized:
* Remove both bounding shape and input shape since core will use that to update the window regions
and if the bounding shape is still set removing the input shape is relatively useless
* Remove the input and bounding shape of the client window since if core tries to update the
shape of the window again (eg the client changes its input shape, or the client is resized) then
it will use the set bounding and input shape on the window, we don't want that.
* Handle shape events and respond appropriately
* Added a small workaround to ensure that the window regions would be immediately updated upon the
shape removal
* Ensure that no other plugins can change the window region
+1 works