Unity

Merge lp://qastaging/~smspillaz/unity/unity.fix_868930 into lp://qastaging/unity

  1. unity.fix_868930
  2. Merge into trunk
Proposed by Sam Spilsbury
Status: Merged
Merged at revision: 1700
Proposed branch: lp://qastaging/~smspillaz/unity/unity.fix_868930
Merge into: lp://qastaging/unity
Diff against target: 107 lines (+22/-15)
3 files modified
plugins/unityshell/src/PluginAdapter.cpp (+9/-9)
plugins/unityshell/src/PluginAdapter.h (+1/-1)
plugins/unityshell/src/unityshell.cpp (+12/-5)
To merge this branch: bzr merge lp://qastaging/~smspillaz/unity/unity.fix_868930
Reviewer Review Type Date Requested Status
Tim Penhey (community) conditional Approve
Review via email: mp+78358@code.qastaging.launchpad.net

Description of the change

Fix bug 868930

To post a comment you must log in.
Revision history for this message
Tim Penhey (thumper) wrote :

How about:

  bool maximized = PluginAdapter::Default()->MaximizeIfBigEnough(window);
  if (!maximized)

I find this easier to read, and the compiler will optimise the temporary out.

review: Approve (conditional)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.