Merge lp://qastaging/~smspillaz/unity/unity.fix_877778 into lp://qastaging/unity
Status: | Merged |
---|---|
Approved by: | Andrea Cimitan |
Approved revision: | no longer in the source branch. |
Merged at revision: | 2245 |
Proposed branch: | lp://qastaging/~smspillaz/unity/unity.fix_877778 |
Merge into: | lp://qastaging/unity |
Diff against target: |
1721 lines (+1167/-284) 8 files modified
plugins/unityshell/src/UnityShowdesktopHandler.cpp (+215/-0) plugins/unityshell/src/UnityShowdesktopHandler.h (+158/-0) plugins/unityshell/src/inputremover.cpp (+7/-3) plugins/unityshell/src/inputremover.h (+27/-5) plugins/unityshell/src/unityshell.cpp (+180/-228) plugins/unityshell/src/unityshell.h (+37/-47) tests/CMakeLists.txt (+4/-1) tests/test_showdesktop_handler.cpp (+539/-0) |
To merge this branch: | bzr merge lp://qastaging/~smspillaz/unity/unity.fix_877778 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Tim Penhey (community) | Approve | ||
Gord Allott | Pending | ||
Review via email:
|
This proposal supersedes a proposal from 2012-04-06.
Commit message
Fixes LP #877778 - Introduces tests for UnityShowdeskto
Description of the change
Fixes LP #877778 - Introduces tests for UnityShowdeskto
== Problem ==
See LP #877778 - in fact, Show Desktop mode was completely broken, but the bug there is mainly about the fact that showdesktoped windows would be invisible in the spread. That's now fixed
== Solution ==
Fix UnityShowdeskto
== Test Coverage ==
Split UnityShowdeskto
Great stuff, but needs to conform to our code style :) namely FooBar() methods and _foo instead of mFoo, quick sed should fix it