Merge lp://qastaging/~smspillaz/unity/unity.maybe_fix_861143 into lp://qastaging/unity

Proposed by Sam Spilsbury
Status: Merged
Approved by: Gord Allott
Approved revision: no longer in the source branch.
Merged at revision: 1686
Proposed branch: lp://qastaging/~smspillaz/unity/unity.maybe_fix_861143
Merge into: lp://qastaging/unity
Diff against target: 282 lines (+95/-34)
6 files modified
plugins/unityshell/src/PanelMenuView.cpp (+36/-3)
plugins/unityshell/src/PanelMenuView.h (+3/-0)
plugins/unityshell/src/PluginAdapter.cpp (+43/-31)
plugins/unityshell/src/PluginAdapter.h (+3/-0)
plugins/unityshell/src/WindowManager.h (+2/-0)
plugins/unityshell/src/unityshell.cpp (+8/-0)
To merge this branch: bzr merge lp://qastaging/~smspillaz/unity/unity.maybe_fix_861143
Reviewer Review Type Date Requested Status
Unity Team Pending
Review via email: mp+77786@code.qastaging.launchpad.net

Description of the change

Maybe fix LP#861143 (I can't reproduce it, but some debugging with Cimi showed what may have been going on)

Instead of explicitly undecorating windows when they are maximized, listen
for changes in decoration state on PropertyNotify events on the windows
themselves and respond to them, because we might get the maximization
event when the window is mapped before compiz has had a chance to decorate
the window.

Also cover the case where a window is withdrawn and then mapped maximized
again, where we wouldn't redecorate those windows.

In order to avoid cycling on our own undecoration requests, we set the
high bit on _MOTIF_WM_HINTS decoration field, if that high bit is
present and the window is otherwise undecorated, we should treat it
like it is still a decorated window and redecorate it when
it is restored. (Applications that explicitly undecorate the window
while this high bit is set are likely to clear the high bit and overwrite the
whole property, so we will be notified when this happens and can respond accordingly)

To post a comment you must log in.
Revision history for this message
Andrea Cimitan (cimi) wrote :

Here fixes the bug

Revision history for this message
Sam Spilsbury (smspillaz) wrote :

Awesome

On Sat, Oct 1, 2011 at 10:43 PM, Andrea Cimitan
<email address hidden> wrote:
> Here fixes the bug
> --
> https://code.launchpad.net/~smspillaz/unity/unity.maybe_fix_861143/+merge/77786
> You are the owner of lp:~smspillaz/unity/unity.maybe_fix_861143.
>

--
Sam Spilsbury

Revision history for this message
Andrea Cimitan (cimi) wrote :

I can test the branch on another PC affected by the bug... Not now though
:-)

Revision history for this message
Andrea Cimitan (cimi) wrote :

Tested on a different pc that was exposing the bug... fixes the issue

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.